[linux] ETP toggle button pixelated on default (active) state
Categories
(Firefox :: Protections UI, defect, P3)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr68 | --- | unaffected |
firefox69 | --- | unaffected |
firefox70 | --- | wontfix |
firefox71 | --- | verified |
firefox72 | --- | verified |
People
(Reporter: cfogel, Assigned: nhnt11)
References
(Regressed 1 open bug, Regression)
Details
(Keywords: regression)
Attachments
(4 files)
Affected versions
- 70.0b13, 71.0a1 (2019-10-07);
Affected platforms
- Ubuntu 16.04
Steps to reproduce
- Launch Firefox, access any website with trackers;
- Click on the Shield button;
- Enable tracking protection if disabled
Expected result
- button is properly displayed;
Actual result
- button appears pixelated / low quality when enabled;
- probably some on-hover residual styling on default state;
Regression range
- Pushlog: URL
- Potential regressor: bug 1584633
Additional notes
- attached recording to illustrate the issue with the issue;
- Windows 7 and macOS 10.13, don't seem to be affected by this issue;
Reporter | ||
Updated•5 years ago
|
Comment 1•5 years ago
|
||
Isn't everything pixelated in that video? I have an Ubuntu VM and on low resolutions (obviously) all the icons are pixelated, while they look fine on higher resolutions. Did you try fiddling with the display resolution? Are all the other icons sharp for you?
Updated•5 years ago
|
Reporter | ||
Comment 2•5 years ago
|
||
Attaching screenshot with an affected build.
Reporter | ||
Comment 3•5 years ago
|
||
Attaching screenshot with an good build.
Assignee | ||
Comment 4•5 years ago
|
||
I think the issue is that --panel-separator-color
evaluates to ThreeDShadow
on Linux, and we're using this color on the border of the switch. We should probably check this out on Windows too... --panel-separator-color
is set to ThreeDLightShadow
there, but seems like it's overridden by a @media (-moz-windows-default-theme)
block - gotta verify what -moz-windows-default-theme
means.
Updated•5 years ago
|
Comment 5•4 years ago
|
||
Nihanth, do you have plans to fix that in 72? Thanks
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Comment 6•4 years ago
|
||
Pushed by nhnt11@gmail.com: https://hg.mozilla.org/integration/autoland/rev/49320c7fe8b3 Don't use --panel-separator-color for TP switch border. r=timhuang
Comment 8•4 years ago
|
||
bugherder |
Comment 9•4 years ago
|
||
Nihanth, do you think that this one line CSS fix could be uplifted to beta? If you do think it's safe, please request the uplift, thanks.
Assignee | ||
Comment 10•4 years ago
|
||
Comment on attachment 9107457 [details]
Bug 1587042 - Don't use --panel-separator-color for TP switch border. r=timhuang!
Beta/Release Uplift Approval Request
- User impact if declined: The ETP toggle switch in the Protections Panel looks pixelated/low-resolution on Linux.
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: No
- Needs manual test from QE?: Yes
- If yes, steps to reproduce: See STR in comment 0 and screenshots in comment 2 and comment 3.
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Simple CSS fix that makes the border color of the TP switch consistent on all platforms.
- String changes made/needed:
Assignee | ||
Updated•4 years ago
|
Updated•4 years ago
|
Comment 11•4 years ago
|
||
Comment on attachment 9107457 [details]
Bug 1587042 - Don't use --panel-separator-color for TP switch border. r=timhuang!
Low risk CSS fix, uplift approved for 71 beta 10, thanks.
Reporter | ||
Comment 12•4 years ago
|
||
Marking fix as verified for 72.0a1(2019.11.13).
Leaving QE+ flag up for Beta 10.
Comment 13•4 years ago
|
||
bugherder uplift |
Reporter | ||
Comment 14•4 years ago
|
||
Verified with the 71.0b10 task_cluster build.
Thanks for the hotfix!
Description
•