1587096 - Implement FinalizationGroup objects in the shell

Status: RESOLVED FIXED

(Core :: JavaScript: GC, task, P3)

Description

[Jon Coppeard (:jonco) (PTO until 3rd April)]

As part of bug 1561074, implement FinalizationGroup objects.

Comment 1

[Jon Coppeard (:jonco) (PTO until 3rd April)]

Attachment: Bug 1587096 - Part 1: Add JS FinalizationGroupObject and related data structures r?sfink

Depends on D49942

Comment 2

[Jon Coppeard (:jonco) (PTO until 3rd April)]

Attachment: Bug 1587096 - Part 2: Add an API to set the HostCleanupFinalizationGroup callback r?sfink

Depends on D49943

Comment 3

[Jon Coppeard (:jonco) (PTO until 3rd April)]

Attachment: Bug 1587096 - Part 3: Implmement FinalizationGroup r?sfink

Depends on D49944

Comment 4

[Jon Coppeard (:jonco) (PTO until 3rd April)]

Attachment: Bug 1587096 - Part 4: Support FinlalizationGroups in the shell and add tests r?sfink

Depends on D49946

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8e609f97c413
Part 1: Add JS FinalizationGroupObject and related data structures r=sfink
https://hg.mozilla.org/integration/autoland/rev/cefc0474e13c
Part 2: Add an API to set the HostCleanupFinalizationGroup callback r=sfink
https://hg.mozilla.org/integration/autoland/rev/b1117df3b91d
Part 3: Implmement FinalizationGroup r=sfink
https://hg.mozilla.org/integration/autoland/rev/ff865fdb64c3
Part 4: Support FinlalizationGroups in the shell and add tests r=sfink

Comment 6

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/8e609f97c413
https://hg.mozilla.org/mozilla-central/rev/cefc0474e13c
https://hg.mozilla.org/mozilla-central/rev/b1117df3b91d
https://hg.mozilla.org/mozilla-central/rev/ff865fdb64c3

Comment 7

[Mathieu Hofman]

Found a problem with the behavior of unregister. Opened Bug 1600488

Comment 8

[Mathieu Hofman]

Found another small quirk in jsshell, but I wouldn't call it a bug.

The FinalizationGroup cleanup callback may create new jobs, e.g. resolving a promise.
I would expect that if calling drainJobQueue() triggers the CleanupFinalizationGroup job, then it would drain any resulting new microtasks.

It's probably a matter of calling js::RunJobs a second time after MaybeRunFinalizationGroupCleanupTasks in RunShellJobs.

Comment 9

[Jon Coppeard (:jonco) (PTO until 3rd April)]

(In reply to Mathieu Hofman from comment #8)

Found another small quirk in jsshell, but I wouldn't call it a bug.

Thanks, that sounds close enough to me. Filed bug 1602741.