158711 - 'Show an Alert' (Mail Alert Notification checkbox) should be hidden for Linux / Mac OS

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[[e-mail] (gone - use [e-mail] instead)]

Build ID: Latest trunk, Linux and Mac OS X 10.1.5 / 9.2.2

Summary: Until we have Mail Alert Notification on Mac and Linux platforms, we
should hide the 'Show an alert' checkbox.

Steps to Reproduce:

1.  Use a platform (Mac OS / Linux) that doesn't do the Mail Alert yet, and notice:
2.  Edit / Preferences / Mail & Newsgroups / 'Show an alert' under 'When new
message arrive:'.

Expected Results:

We should hide the following checkbox:

<hbox align="center">
  <checkbox id="newMailNotificationAlert" label="&showAnimatedAlert.label;"
                   prefstring="mail.biff.show_alert"
                   accesskey="&showAnimatedAlert.accesskey;" />
</hbox>

Actual Results:

It remains as a pref.

We should do this for Buffy - sorry this was missed for MachV.

Comment 1

[[e-mail] (gone - use [e-mail] instead)]

*** Bug 183528 has been marked as a duplicate of this bug. ***

Comment 2

[[e-mail] (gone - use [e-mail] instead)]

*** Bug 180305 has been marked as a duplicate of this bug. ***

Comment 3

[Samir Gehani]

Mail triage team: nsbeta1+/adt3

Comment 4

[(not reading, please use [e-mail] instead)]

re-assigning nsbeta1+ bugs

Comment 5

[(not reading, please use [e-mail] instead)]

I think the fix for this should be to see if a call to 

getservice("@mozilla.org/alerts-service;1") fails or not.

if it fails, we hide this UI.

Comment 6

[(not reading, please use [e-mail] instead)]

Attachment: testing this patch now...

Comment 7

[(not reading, please use [e-mail] instead)]

this works on win32 and linux.

the reason it does is because of mozilla/xpfe/components/Makefile.in

ifeq ($(OS_ARCH),WINNT)
DIRS		+= winhooks urlwidget alerts
endif

the alerts service is conditionally built, so this code does the right thing.

Comment 8

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 112949 [details] [diff] [review]
testing this patch now...

r+sr=dmose

Comment 9

[Asa Dotzler [:asa]]

Comment on attachment 112949 [details] [diff] [review]
testing this patch now...

a=asa (on behalf of drivers) for checkin to 1.3beta.

Comment 10

[(not reading, please use [e-mail] instead)]

fixed.

thanks to hiz-ammer for the bug report.

Comment 11

[[e-mail]]

This works but it's the wrong fix.

Comment 12

[[e-mail]]

Attachment: Proposed patch

Comment 13

[[e-mail]]

Comment on attachment 113100 [details] [diff] [review]
Proposed patch

Use of |in| is preferable to try/catch

Comment 14

[(not reading, please use [e-mail] instead)]

Comment on attachment 113100 [details] [diff] [review]
Proposed patch

r/sr=sspitzer

thanks neil.

Comment 15

[[e-mail]]

Comment on attachment 113100 [details] [diff] [review]
Proposed patch

Seth, please can I leave it to you to ask for a= if you feel it appropriate?

Comment 16

[(not reading, please use [e-mail] instead)]

Comment on attachment 113100 [details] [diff] [review]
Proposed patch

assuming you tested it well (win32 and linux), sr=sspitzer

let me know if you want help testing this (or any other patch) on a platform
you might not have.

Comment 17

[(not reading, please use [e-mail] instead)]

my first fix landed (so this UI won't show in 1.3 beta bits)

I think the code cleanup can wait until the start of 1.3 final.

neil, I'll re-assign to you so you can mark fixed once you check in the code
cleanup.

Comment 18

[[e-mail]]

Pushing out as I understand that drivers are not accepting cleanup for 1.3final

Comment 19

[[e-mail]]

Fix checked in.

Comment 20

[Ninoschka Baca]

Trunk build 2003-03-07: Mac 10.1.5, Linux RH 8
Verified Fixed.