Closed Bug 1587134 Opened Last month Closed 25 days ago

[wpt-sync] Sync PR 19574 - [LayoutNG] Fix font-orientation segmentation

Categories

(Core :: CSS Parsing and Computation, task, P4)

task

Tracking

()

RESOLVED FIXED
mozilla71
Tracking Status
firefox71 --- fixed

People

(Reporter: wptsync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 19574 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/19574
Details from upstream follow.

Koji Ishii <kojii@chromium.org> wrote:

[LayoutNG] Fix font-orientation segmentation

When there are no script segments (i.e., all the text is in
single script) and in vertical flow, we create a single
segment and split it at the font-orientation boundaries.

This patch fixes to create the single segment from the first
text item, not from the first item. If it is created from the
first item and the first item is not a text item, we may give
incorrect script and/or font-orientation to HarfBuzz.

Bug: 1006154
Change-Id: I5ea87920f8cbc76cdc13fe25611f7a7a34284813

Reviewed-on: https://chromium-review.googlesource.com/1847697
WPT-Export-Revision: 8ecc6f944bbee6bd8ec11d439c128aca62af8efc

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
## GitHub CI Results
wpt.fyi [PR Results](https://wpt.fyi/results/?sha=b5e32bcd50cc5d33a91a12e5952c8b0d848cd343&label=pr_head) [Base Results](https://wpt.fyi/results/?sha=b5e32bcd50cc5d33a91a12e5952c8b0d848cd343&label=pr_base)

Ran 1 tests

### Firefox
  PASS: 1

### Chrome
  PASS: 1

### Safari
  PASS: 1
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/41d2f4d36b66
[wpt PR 19574] - [LayoutNG] Fix font-orientation segmentation, a=testonly
Status: NEW → RESOLVED
Closed: 25 days ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
You need to log in before you can comment on or make changes to this bug.