1587339 - [wpt-sync] Sync PR 19589 - Stop using private properties for data properties of cross-origin properties

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 19589 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/19589
Details from upstream follow.

Marina Sakai <[e-mail]> wrote:

Stop using private properties for data properties of cross-origin properties

Since Blink properly supports the incumbent realm now, there is no more need to use OriginSafeMethodSetter, which sets value via V8PrivateProperty.
So there is no need to use V8PrivateProperty also in OriginSafeMethodGetter.

This CL makes it possible to handle "data properties" of cross-origin properties as the proper data properties.

Bug: 715418
Change-Id: I336a8459b80bc63d08a248f3ed7a34dc0806e5ab
Reviewed-on: https://chromium-review.googlesource.com/1844520
WPT-Export-Revision: e40cd5c1f70f050f6c3b6d75236d5fcd79bc018d

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=d31463a516cc40ce18f94c02adedc1006299f68b

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

## GitHub CI Results
wpt.fyi [PR Results](https://wpt.fyi/results/?sha=ee21d1c24fccd4bb58a6916fd021d486a6ca73e2&label=pr_head) [Base Results](https://wpt.fyi/results/?sha=ee21d1c24fccd4bb58a6916fd021d486a6ca73e2&label=pr_base)

Ran 1 tests and 114 subtests

### Firefox
  OK     : 1
  PASS   : 102

### Chrome
  OK     : 1
  PASS   : 39
  FAIL   : 51

### Safari
  OK     : 1
  PASS   : 84
  FAIL   : 18

### New tests that's don't pass

/html/browsers/origin/cross-origin-objects/cross-origin-objects.html
   proto setter |call| on cross-origin Location with null (function set __proto__() {
    [native code]
}, E): Firefox: MISSING, Chrome: MISSING, Safari: PASS
   proto setter |call| on cross-origin Location with null (function set __proto__() {
    [native code]
}, G): Firefox: MISSING, Chrome: MISSING, Safari: PASS
   proto setter |call| on cross-origin Location with null (function (p) { Object.setPrototypeOf(this, p); }, G): Firefox: MISSING, Chrome: MISSING, Safari: PASS
   proto setter |call| on cross-origin Location with null (function set __proto__() {
    [native code]
}, C): Firefox: MISSING, Chrome: MISSING, Safari: PASS
   proto setter |call| on cross-origin Window with null (function set __proto__() {
    [native code]
}, E): Firefox: MISSING, Chrome: MISSING, Safari: PASS
   proto setter |call| on cross-origin Window with null (function (p) { Object.setPrototypeOf(this, p); }, C): Firefox: MISSING, Chrome: MISSING, Safari: PASS
   proto setter |call| on cross-origin Window with null (function set __proto__() {
    [native code]
}, G): Firefox: MISSING, Chrome: MISSING, Safari: PASS
   proto setter |call| on cross-origin Window with null (function (p) { Object.setPrototypeOf(this, p); }, G): Firefox: MISSING, Chrome: MISSING, Safari: PASS
   proto setter |call| on cross-origin Window with null (function set __proto__() {
    [native code]
}, C): Firefox: MISSING, Chrome: MISSING, Safari: PASS
   proto setter |call| on cross-origin Window with null (function (p) { Object.setPrototypeOf(this, p); }, E): Firefox: MISSING, Chrome: MISSING, Safari: PASS
   proto setter |call| on cross-origin Location with null (function (p) { Object.setPrototypeOf(this, p); }, E): Firefox: MISSING, Chrome: MISSING, Safari: PASS
   proto setter |call| on cross-origin Location with null (function (p) { Object.setPrototypeOf(this, p); }, C): Firefox: MISSING, Chrome: MISSING, Safari: PASS

## Gecko CI Results

Ran 1 tests and 102 subtests
  OK     : 1
  PASS   : 102

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/def69ce8f0e0
[wpt PR 19589] - Stop using private properties for data properties of cross-origin properties, a=testonly

Comment 4

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/def69ce8f0e0