1587382 - Provide application as a new perf signature property

Status: RESOLVED FIXED

(Tree Management :: Perfherder, task, P3)

Description

[Ionuț Goldan [:igoldan]]

Currently, performance_signatures have the following properties which define them & together ensure their uniqueness:

• repository
• framework
• platform
• option_collection
• suite
• test
• last_updated
• extra_options

We need to add a new browser application property, so we can (for example) easily bring the Chrome/Chromium perf data variants, when we're viewing the Firefox ones.

Comment 1

[Dave Hunt [:davehunt] [he/him] ⌚BST]

I would suggest the more generic application rather than browser, and also consider an application_version.

Comment 2

[Dave Hunt [:davehunt] [he/him] ⌚BST]

See also bug 1587576, which adds some support for obtaining browser metadata.

Comment 3

[Ionuț Goldan [:igoldan]]

(In reply to Dave Hunt [:davehunt] [he/him] ⌚BST from comment #1)

I would suggest the more generic application rather than browser,

Good idea.

and also consider an application_version.

My gut feeling says we cannot support application_version during this quarter. But will do some research to properly confirm that.

Still, if we've reached this subject... It's reasonable to assume that application is a data decoupling factor.
But I consider application_version to not be a data decoupling factor. After we, let's say update Chrome's version used in our CI, we should still see data points collected under the same signature. That way, we'll be able to be alerted on changes like these & label them as test harness changes.
After all, that's how we've handled updates to mitmproxy, when we've switched from 2.0.2 to 4.0.4. Bebe, hopefully I'm right here. Could you please confirm this, if you have a better memory than mine?

Dave, am I right about this assumption?

Comment 4

[Dave Hunt [:davehunt] [he/him] ⌚BST]

(In reply to Ionuț Goldan [:igoldan], Performance Sheriff from comment #3)

Dave, am I right about this assumption?

I agree, let's revisit application_version in the future if desired.

Comment 5

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Is there anything left to do here?

Comment 6

[Ionuț Goldan [:igoldan]]

(In reply to Dave Hunt [:davehunt] [he/him] ⌚BST from comment #5)

Is there anything left to do here?

Nope. We're done here.