Closed Bug 1587390 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 19595 - Switch WebKitGTK testing to Ubuntu and add a nightly channel

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox72 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla72
Tracking Flags:
Tracking Status
firefox72 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 19595 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/19595
Details from upstream follow.

Carlos Alberto Lopez Perez <clopez@igalia.com> wrote:

Switch WebKitGTK testing to Ubuntu and add a nightly channel

This PR adds two changes:

  1. Switches testing with WebKitGTK to Ubuntu (removes the need for the extra dockerfile)

    Previously (#18595 and #19466) a Dockerfile based on Debian was added for WebKitGTK testing with the idea of reusing the built products that build.webkit.org is producing.

    That was done with the idea of having dozens of new nightly builds available at a day, which doesn't seem to match the needs for WPT testing/runs. It seems that having one new nightly a day (or even two a week) is more than enough. At that rate is more than reasonable to do new builds for testing with Ubuntu 18.04.

    And it seems that harmonizing the testing of the Linux based browsers on the same docker image has several benefits, including making easier future maintenance.

  2. Adds a nightly channel for testing with WebKitGTK on taskcluster.

    The nighly channel downloads the last nightly tarball available at https://webkitgtk.org/built-products and installs it on taskcluster when the test start.

    This tarball is generated using the webkitgtk internal JHBuild, that builds several third-party libraries needed for webkitgtk layout tests and then builds webkitgtk on top of this libraries.
    Because of this, to use this tarball it is required to installing quite a lot of extra dependencies (that are needed by this extra third-party libraries).

    A script is included inside the tarball to install this dependencies. This script is executed at test time in task cluster. But because installing them take quite a bit of time (several minutes), the dockerfile is modified to have them already installed and speed up this process. Having them already installed on the docker image is not strictly necessary, it just speed up the testing process.

//cc @jgraham @foolip

PR 19595 applied with additional changes from upstream: abb820ae83ffb82ccd8380ce61685b51329a7b07, 9f0aff8885b01a38dcce738c02c58bd66300a25d, 67b7546935596dc4236dfe84fd153eedf4be469f
PR 19595 applied with additional changes from upstream: abb820ae83ffb82ccd8380ce61685b51329a7b07, 9f0aff8885b01a38dcce738c02c58bd66300a25d, 67b7546935596dc4236dfe84fd153eedf4be469f
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/458f5263bbca
[wpt PR 19595] - Switch WebKitGTK testing to Ubuntu and add a nightly channel, a=testonly

https://hg.mozilla.org/mozilla-central/rev/458f5263bbca

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox72: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
You need to log in before you can comment on or make changes to this bug.