Open Bug 1587396 Opened 2 years ago Updated 2 days ago

Thunderbird-only read of AppType from root docshell in CanLoadImage uses nsIDocShellTreeItem

Categories

(Core :: DOM: Navigation, defect, P5)

defect

Tracking

()

Fission Milestone Future

People

(Reporter: djvj, Unassigned)

References

(Blocks 2 open bugs)

Details

Attachments

(3 files)

https://searchfox.org/mozilla-central/rev/7cc0f0e89cb40e43bf5c96906f13d44705401042/dom/base/nsContentUtils.cpp#3152

Retrieves AppType of root docshell. This state can be synchronized, probably to TabContext.

Whiteboard: [rm-docshell-tree-item:sync-state]
Fission Milestone: --- → M5
Priority: -- → P2
Fission Milestone: M5 → Future

Kannan says replacing nsIDocShellTreeItem calls should block enabling Fission in Nightly (M6).

Fission Milestone: Future → M6
Assignee: nobody → tetsuharu.ohzeki
Status: NEW → ASSIGNED

I don't think we need to fix this usage of nsIDocShellTreeItem, as it will always be APP_TYPE_UNKNOWN when running in firefox (https://searchfox.org/mozilla-central/rev/d6f957415cf009995ecb539ef1425316d82164a9/docshell/base/nsIDocShell.idl#270-271), and thunderbird doesn't support e10s or Fission.

I'm sorry for not catching this bug, and moving it out of M6, before you started working on it.

Fission Milestone: M6 → Future
Priority: P2 → P5
Summary: Fix usage of nsIDocShellTreeItem in nsContentUtils::CanLoadImage → Thunderbird-only read of AppType from root docshell in CanLoadImage uses nsIDocShellTreeItem
Whiteboard: [rm-docshell-tree-item:sync-state]

(In reply to :Nika Layzell (ni? for response) from comment #5)

I don't think we need to fix this usage of nsIDocShellTreeItem, as it will always be APP_TYPE_UNKNOWN when running in firefox (https://searchfox.org/mozilla-central/rev/d6f957415cf009995ecb539ef1425316d82164a9/docshell/base/nsIDocShell.idl#270-271), and thunderbird doesn't support e10s or Fission.

I'm sorry for not catching this bug, and moving it out of M6, before you started working on it.

Aha, okay.

By the way, can we postpone other bugs which toucing nsIDocShell::AppType (e.g. bug 1587406, bug 1597454) as the same with this?

Flags: needinfo?(nika)

(In reply to Tetsuharu OHZEKI [:tetsuharu] [UTC+9] from comment #6)

By the way, can we postpone other bugs which toucing nsIDocShell::AppType (e.g. bug 1587406, bug 1597454) as the same with this?

Yes we can. Thanks for catching those other bugs!

Flags: needinfo?(nika)

Tetsuharu, is this AppType bug and your attached patches still relevant? Fission will soon be enabled by default for all Firefox users.

Flags: needinfo?(tetsuharu.ohzeki)

As my understanding, I think this bug is not a blocker for fission by the reason which Nika said in in comment #5.

To eliminate nsIDocShellTreeItem , we would requires changes which are did in my attached patches, but I think that such effort is not a blocker for fission as tracked in bug 1607591. https://searchfox.org/mozilla-central/rev/997b16c37aa3471386098a5ab78e0db486df8973/dom/base/nsContentUtils.cpp#3455

Flags: needinfo?(tetsuharu.ohzeki)

I unassigned me once.

Assignee: tetsuharu.ohzeki → nobody
Status: ASSIGNED → NEW
You need to log in before you can comment on or make changes to this bug.