Closed Bug 1587397 Opened 4 months ago Closed 2 months ago

Fix usage of nsIDocShellTreeItem in nsContentUtils::IsChildOfSameType

Categories

(Core :: DOM: Navigation, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla73
Fission Milestone M6
Tracking Status
firefox73 --- fixed

People

(Reporter: djvj, Assigned: djvj)

References

(Blocks 1 open bug)

Details

(Whiteboard: [rm-docshell-tree-item:simple])

Attachments

(1 file)

https://searchfox.org/mozilla-central/rev/7cc0f0e89cb40e43bf5c96906f13d44705401042/dom/base/nsContentUtils.cpp#3766

Simple fix. Checks of docshell is the child of a same-type parent - i.e. whether this child is a same-type root. Logic can be changed to use BrowsingContext instead.

Whiteboard: [rm-docshell-tree-item:simple]
Fission Milestone: --- → M5
Priority: -- → P2
Fission Milestone: M5 → Future

Kannan says replacing nsIDocShellTreeItem calls should block enabling Fission in Nightly (M6).

Fission Milestone: Future → M6
Assignee: nobody → kvijayan
Pushed by kvijayan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2395ca255ae6
Fix usage of nsIDocShellTreeItem in nsContentUtils::IsChildOfSameType. r=kmag
Status: NEW → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla73
You need to log in before you can comment on or make changes to this bug.