Closed Bug 1587466 Opened 6 years ago Closed 6 years ago

Specifying "r?#build" in commit description is not recognized by moz-phab

Categories

(Conduit :: moz-phab, defect)

x86_64
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WORKSFORME

People

(Reporter: decoder, Unassigned)

Details

When I used the following commit description

Bug 1587065 - Use the TSan suppression list in test automation. r?#build

and then submitted the patch using moz-phab submit, moz-phab apparently stripped the r? from the commit message and submitted the patch to Phabricator without a reviewer.

The resulting description in Phabricator was:

Bug 1587065 - Use the TSan suppression list in test automation. #build

The respective review is here: https://phabricator.services.mozilla.com/D48614

I can't replicate:
I've create a revision with a commit message:

$ hg log
changeset:   8:98f6563bb299
[...]
summary:     Bug 1394742 - Use the TSan suppression list in test automation. r?#build

Then called MozPhab:

$ moz-phab .
Submitting 1 commit for review:
(New) 8:98f6563bb299 Bug 1394742 - Use the TSan suppression list in test automation. r?#build
[...]
Completed
(D1436) 9:8e54847f681e Bug 1394742 - Use the TSan suppression list in test automation. r?#build
-> https://phabricator-dev.allizom.org/D1436

The revision is properly created in Phabricator https://phabricator-dev.allizom.org/D1436
Please reopen if it will happen again.

Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.