Closed Bug 1587492 Opened 5 years ago Closed 5 years ago

Provide a policy to force the menubar on or off

Categories

(Firefox :: Enterprise Policies, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
Firefox 72
Tracking Status
firefox-esr68 --- fixed
firefox72 --- fixed

People

(Reporter: mkaply, Assigned: mkaply)

References

Details

Attachments

(1 file)

IE provides a policy to force the menu bar to be always on.

We should add that (It's been requested by customers as well)

The current policy sets the default but allows it to be turned off.

Pushed by mozilla@kaply.com:
https://hg.mozilla.org/integration/autoland/rev/f723268009a9
Add a new policy to always show the menubar. r=Gijs

Backed out changeset f723268009a9 (Bug 1587492) for browser chrome failure at browser/browser_policy_display_menu.js

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=f723268009a980b6fc7cfb585b1f24bffb2f5ef8

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=274141742&repo=autoland&lineNumber=2834

Backout link: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=f6e4dc9f84c9c7b76304ac54f25f4e32e5a268a1

[task 2019-11-01T18:56:33.850Z] 18:56:33     INFO - TEST-PASS | browser/components/enterprisepolicies/tests/browser/browser_policy_display_menu.js | Sanity check the temporary file doesn't exist. - true == true - 
[task 2019-11-01T18:56:33.850Z] 18:56:33     INFO - Console message: OpenGL compositor Initialized Succesfully.
[task 2019-11-01T18:56:33.850Z] 18:56:33     INFO - Version: 2.1 INTEL-12.9.22
[task 2019-11-01T18:56:33.850Z] 18:56:33     INFO - Vendor: Intel Inc.
[task 2019-11-01T18:56:33.850Z] 18:56:33     INFO - Renderer: Intel Iris OpenGL Engine
[task 2019-11-01T18:56:33.850Z] 18:56:33     INFO - FBO Texture Target: TEXTURE_2D
[task 2019-11-01T18:56:33.850Z] 18:56:33     INFO - TEST-PASS | browser/components/enterprisepolicies/tests/browser/browser_policy_display_menu.js | The menu bar should not be hidden - 
[task 2019-11-01T18:56:33.850Z] 18:56:33     INFO - Buffered messages finished
[task 2019-11-01T18:56:33.850Z] 18:56:33     INFO - TEST-UNEXPECTED-FAIL | browser/components/enterprisepolicies/tests/browser/browser_policy_display_menu.js | Menu bar should have a toolbarname - Got false, expected true
[task 2019-11-01T18:56:33.851Z] 18:56:33     INFO - Stack trace:
[task 2019-11-01T18:56:33.851Z] 18:56:33     INFO - chrome://mochikit/content/browser-test.js:test_is:1314
[task 2019-11-01T18:56:33.851Z] 18:56:33     INFO - chrome://mochitests/content/browser/browser/components/enterprisepolicies/tests/browser/browser_policy_display_menu.js:test_menu_shown_string:42
[task 2019-11-01T18:56:33.851Z] 18:56:33     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1069
[task 2019-11-01T18:56:33.851Z] 18:56:33     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1104
[task 2019-11-01T18:56:33.851Z] 18:56:33     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:932
[task 2019-11-01T18:56:33.851Z] 18:56:33     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:805
[task 2019-11-01T18:56:33.851Z] 18:56:33     INFO - Leaving test bound test_menu_shown_string
[task 2019-11-01T18:56:33.851Z] 18:56:33     INFO - Entering test bound test_menubar_on
Flags: needinfo?(mozilla)
Pushed by mozilla@kaply.com:
https://hg.mozilla.org/integration/autoland/rev/c1d881c71097
Add a new policy to always show the menubar. r=Gijs
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 72

Relanded.

Flags: needinfo?(mozilla)

Should we mention this in the enterprise section of the 72 release notes? Or do we just update https://github.com/mozilla/policy-templates#displaymenubar?

Flags: needinfo?(mozilla)

(In reply to Julien Cristau [:jcristau] from comment #7)

Should we mention this in the enterprise section of the 72 release notes? Or do we just update https://github.com/mozilla/policy-templates#displaymenubar?

We don't typically put policy updates in the enterprise readme. I'll be adding it to the policy release information.

Flags: needinfo?(mozilla)

Comment on attachment 9099933 [details]
Bug 1587492 - Add a new policy to always show the menubar.

ESR Uplift Approval Request

  • If this is not a sec:{high,crit} bug, please state case for ESR consideration: New policy addition
  • User impact if declined: No policy for menubar
  • Fix Landed on Version: 71
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Policy only, has automated tests.
  • String or UUID changes made by this patch:
Attachment #9099933 - Flags: approval-mozilla-esr68?

Comment on attachment 9099933 [details]
Bug 1587492 - Add a new policy to always show the menubar.

Adds a policy which already shipped in Fx72 to maintain parity between ESR and Release. Approved for 68.5esr.

Attachment #9099933 - Flags: approval-mozilla-esr68? → approval-mozilla-esr68+
Regressions: 1616832
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: