Provide a policy to force the menubar on or off
Categories
(Firefox :: Enterprise Policies, enhancement, P3)
Tracking
()
People
(Reporter: mkaply, Assigned: mkaply)
References
Details
Attachments
(1 file)
47 bytes,
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-esr68+
|
Details | Review |
IE provides a policy to force the menu bar to be always on.
We should add that (It's been requested by customers as well)
The current policy sets the default but allows it to be turned off.
Assignee | ||
Comment 1•5 years ago
|
||
Pushed by mozilla@kaply.com: https://hg.mozilla.org/integration/autoland/rev/f723268009a9 Add a new policy to always show the menubar. r=Gijs
Comment 3•5 years ago
|
||
Backed out changeset f723268009a9 (Bug 1587492) for browser chrome failure at browser/browser_policy_display_menu.js
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=274141742&repo=autoland&lineNumber=2834
[task 2019-11-01T18:56:33.850Z] 18:56:33 INFO - TEST-PASS | browser/components/enterprisepolicies/tests/browser/browser_policy_display_menu.js | Sanity check the temporary file doesn't exist. - true == true -
[task 2019-11-01T18:56:33.850Z] 18:56:33 INFO - Console message: OpenGL compositor Initialized Succesfully.
[task 2019-11-01T18:56:33.850Z] 18:56:33 INFO - Version: 2.1 INTEL-12.9.22
[task 2019-11-01T18:56:33.850Z] 18:56:33 INFO - Vendor: Intel Inc.
[task 2019-11-01T18:56:33.850Z] 18:56:33 INFO - Renderer: Intel Iris OpenGL Engine
[task 2019-11-01T18:56:33.850Z] 18:56:33 INFO - FBO Texture Target: TEXTURE_2D
[task 2019-11-01T18:56:33.850Z] 18:56:33 INFO - TEST-PASS | browser/components/enterprisepolicies/tests/browser/browser_policy_display_menu.js | The menu bar should not be hidden -
[task 2019-11-01T18:56:33.850Z] 18:56:33 INFO - Buffered messages finished
[task 2019-11-01T18:56:33.850Z] 18:56:33 INFO - TEST-UNEXPECTED-FAIL | browser/components/enterprisepolicies/tests/browser/browser_policy_display_menu.js | Menu bar should have a toolbarname - Got false, expected true
[task 2019-11-01T18:56:33.851Z] 18:56:33 INFO - Stack trace:
[task 2019-11-01T18:56:33.851Z] 18:56:33 INFO - chrome://mochikit/content/browser-test.js:test_is:1314
[task 2019-11-01T18:56:33.851Z] 18:56:33 INFO - chrome://mochitests/content/browser/browser/components/enterprisepolicies/tests/browser/browser_policy_display_menu.js:test_menu_shown_string:42
[task 2019-11-01T18:56:33.851Z] 18:56:33 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1069
[task 2019-11-01T18:56:33.851Z] 18:56:33 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1104
[task 2019-11-01T18:56:33.851Z] 18:56:33 INFO - chrome://mochikit/content/browser-test.js:nextTest/<:932
[task 2019-11-01T18:56:33.851Z] 18:56:33 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:805
[task 2019-11-01T18:56:33.851Z] 18:56:33 INFO - Leaving test bound test_menu_shown_string
[task 2019-11-01T18:56:33.851Z] 18:56:33 INFO - Entering test bound test_menubar_on
Pushed by mozilla@kaply.com: https://hg.mozilla.org/integration/autoland/rev/c1d881c71097 Add a new policy to always show the menubar. r=Gijs
Comment 5•5 years ago
|
||
bugherder |
Comment 7•4 years ago
|
||
Should we mention this in the enterprise section of the 72 release notes? Or do we just update https://github.com/mozilla/policy-templates#displaymenubar?
Assignee | ||
Comment 8•4 years ago
|
||
(In reply to Julien Cristau [:jcristau] from comment #7)
Should we mention this in the enterprise section of the 72 release notes? Or do we just update https://github.com/mozilla/policy-templates#displaymenubar?
We don't typically put policy updates in the enterprise readme. I'll be adding it to the policy release information.
Assignee | ||
Comment 9•4 years ago
|
||
Comment on attachment 9099933 [details]
Bug 1587492 - Add a new policy to always show the menubar.
ESR Uplift Approval Request
- If this is not a sec:{high,crit} bug, please state case for ESR consideration: New policy addition
- User impact if declined: No policy for menubar
- Fix Landed on Version: 71
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Policy only, has automated tests.
- String or UUID changes made by this patch:
Comment 10•4 years ago
|
||
Comment on attachment 9099933 [details]
Bug 1587492 - Add a new policy to always show the menubar.
Adds a policy which already shipped in Fx72 to maintain parity between ESR and Release. Approved for 68.5esr.
Comment 11•4 years ago
|
||
bugherder uplift |
Description
•