Closed
Bug 1587502
Opened 5 years ago
Closed 5 years ago
Do not override `wait` shared helper in netmonitor tests
Categories
(DevTools :: Netmonitor, task, P3)
DevTools
Netmonitor
Tracking
(firefox71 fixed)
RESOLVED
FIXED
Firefox 71
| Tracking | Status | |
|---|---|---|
| firefox71 | --- | fixed |
People
(Reporter: jdescottes, Assigned: jdescottes)
References
Details
Attachments
(1 file)
There are a lot of netmonitor tests which override the wait global. They assign it to a temporary promise.
wait is a shared helper defined in devtools' shared-head.js :
https://searchfox.org/mozilla-central/rev/05a22d864814cb1e4352faa4004e1f975c7d2eb9/devtools/client/shared/test/shared-head.js#458
Example of an incorrect override: https://searchfox.org/mozilla-central/rev/05a22d864814cb1e4352faa4004e1f975c7d2eb9/devtools/client/netmonitor/test/browser_net-ws-filter-freetext.js#35
After the override, calling wait() will fail.
Spotted while working on Bug 1565200, because I am trying to wait() in one of our cleanup methods while I work out some issues with the JsWindowActors implementation.
|
Assignee | |
Comment 1•5 years ago
|
||
Pushed by jdescottes@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9ca5e74ff85c Do not override the wait global in netmonitor tests r=Honza
|
||
Comment 3•5 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox71:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 71
You need to log in
before you can comment on or make changes to this bug.
Description
•