Closed Bug 1587575 Opened 6 years ago Closed 5 years ago

Replace JitcodeGlobalEntry::BytecodeLocation with bytecode interface class BytecodeLocation

Categories

(Core :: JavaScript Engine, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
83 Branch
Tracking Status
firefox83 --- fixed

People

(Reporter: asorholm, Assigned: yozaam)

References

Details

(Whiteboard: [lang=c++])

Attachments

(1 file)

Replace JitcodeGlobalEntry::BytecodeLocation¹ with bytecode interface class BytecodeLocation².

Can take advantage of the fact that all the consumers of the JSScript* script³ field are debug only. (Thanks to @mgaudet for that observation.)

1: https://searchfox.org/mozilla-central/source/js/src/jit/JitcodeMap.h#138
2: https://searchfox.org/mozilla-central/source/js/src/vm/BytecodeLocation.h#33
3: https://searchfox.org/mozilla-central/source/js/src/jit/JitcodeMap.h#139

Priority: -- → P3
Assignee: nobody → yozaam
Status: NEW → ASSIGNED
Attachment #9178389 - Attachment description: Bug 1587575 removed JitcodeGlobalEntry::BytecodeLocation struct, r=mgaudet → Bug 1587575 removed JitcodeGlobalEntry::BytecodeLocation r=mgaudet
Attachment #9178389 - Attachment description: Bug 1587575 removed JitcodeGlobalEntry::BytecodeLocation r=mgaudet → Bug 1587575 - Replace JitcodeGlobalEntry::BytecodeLocation with js::BytecodeLocation r=mgaudet
Pushed by mgaudet@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c5d592c3952b Replace JitcodeGlobalEntry::BytecodeLocation with js::BytecodeLocation r=mgaudet
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → 83 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: