Closed Bug 1587691 Opened 10 months ago Closed 10 months ago

Webchannel "login" message should handle sync being configured without declined/accepted engines.

Categories

(Firefox :: Firefox Accounts, defect, P1)

defect

Tracking

()

RESOLVED FIXED
Firefox 71
Tracking Status
firefox71 --- fixed

People

(Reporter: markh, Assigned: markh)

References

Details

Attachments

(1 file)

In the login webchannel message, desktop will fail if declinedEngines or offeredEngines is anything other than an array. However, we want the ability to enable sync without touching declined engines locally for bug 1587450.

Even if we do this, the Firefox Accounts server remains in control of the behavior - if we later change policy to never enable sync without offering what to sync, that becomes a server-only change - so this change alone doesn't cause any behaviour change - it just allows more flexibility in the behaviour changes which FxA can cause.

Pushed by eoger@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fdcf84573587
Firefox Accounts webchannel message should allow login without engine choices. r=eoger
Status: ASSIGNED → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 71

Hello,
If this requires manual testing could you please provide some steps in order to reproduce and verify the issue?

Flags: needinfo?(markh)

Thanks, but we've already done all manual testing necessary.

Flags: needinfo?(markh) → qe-verify-
You need to log in before you can comment on or make changes to this bug.