1587691 - Webchannel "login" message should handle sync being configured without declined/accepted engines.

Status: RESOLVED FIXED

(Firefox :: Firefox Accounts, defect, P1)

Description

[Mark Hammond [:markh] [:mhammond]]

In the login webchannel message, desktop will fail if declinedEngines or offeredEngines is anything other than an array. However, we want the ability to enable sync without touching declined engines locally for bug 1587450.

Even if we do this, the Firefox Accounts server remains in control of the behavior - if we later change policy to never enable sync without offering what to sync, that becomes a server-only change - so this change alone doesn't cause any behaviour change - it just allows more flexibility in the behaviour changes which FxA can cause.

Comment 1

[Mark Hammond [:markh] [:mhammond]]

Attachment: Bug 1587691 - Firefox Accounts webchannel message should allow login without engine choices. r?vladikoff,eoger

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fdcf84573587
Firefox Accounts webchannel message should allow login without engine choices. r=eoger

Comment 3

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/fdcf84573587

Comment 4

[Miruna Curtean]

Hello,
If this requires manual testing could you please provide some steps in order to reproduce and verify the issue?

Comment 5

[Mark Hammond [:markh] [:mhammond]]

Thanks, but we've already done all manual testing necessary.