1587701 - Make toolbox's highlight/unhighlight functions work in the browser toolbox for content element

Status: RESOLVED FIXED

(DevTools :: Shared Components, task, P1)

Description

[Nicolas Chevobbe [:nchevobbe]]

The getHighlighter (devtools/client/framework/toolbox.js#3336-3381) function returns an object with 2 highlight/unhighlight functions, that can then be called with a grip.

With Bug 1586201, we'll have a way to get the appropriate nodeFront from an element grip, which means we can use that to retrieve the appropriate highlighter, and be able to highlight a logged content node element from the browser toolbox.

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1587701 - Use toolbox's getNodeFrontFromNodeGrip in highlight method. r=pbro.

This allow us to retrieve the appropriate nodeFront from a grip,
and thus the right highlighterFront to highlight a given element.
We also need to cache the highlighter front used for the current
highlight, as we need to use the same front for unhighlighting,
and this saves us a few server round-trip to get the right front.

Depends on D48808

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/045d50e021e4
Use toolbox's getNodeFrontFromNodeGrip in highlight method. r=pbro.

Comment 3

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/045d50e021e4