Closed Bug 1587701 Opened 3 months ago Closed 3 months ago

Make toolbox's highlight/unhighlight functions work in the browser toolbox for content element

Categories

(DevTools :: Shared Components, task, P1)

task

Tracking

(firefox71 fixed)

RESOLVED FIXED
Firefox 71
Tracking Status
firefox71 --- fixed

People

(Reporter: nchevobbe, Assigned: nchevobbe)

References

(Blocks 1 open bug)

Details

(Whiteboard: dt-fission dt-fission-m1)

Attachments

(1 file)

The getHighlighter (devtools/client/framework/toolbox.js#3336-3381) function returns an object with 2 highlight/unhighlight functions, that can then be called with a grip.

With Bug 1586201, we'll have a way to get the appropriate nodeFront from an element grip, which means we can use that to retrieve the appropriate highlighter, and be able to highlight a logged content node element from the browser toolbox.

Whiteboard: dt-fission-browser-console → dt-fission

This allow us to retrieve the appropriate nodeFront from a grip,
and thus the right highlighterFront to highlight a given element.
We also need to cache the highlighter front used for the current
highlight, as we need to use the same front for unhighlighting,
and this saves us a few server round-trip to get the right front.

Depends on D48808

Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/045d50e021e4
Use toolbox's getNodeFrontFromNodeGrip in highlight method. r=pbro.
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 71
Whiteboard: dt-fission → dt-fission dt-fission-m1
You need to log in before you can comment on or make changes to this bug.