1587737 - The saved logins are not displayed in the “Login List” from the “about:logins” page after signing in to Sync

Status: VERIFIED FIXED

(Firefox :: Sync, defect)

Description

[Simona Rosu [:srosu], Ecosystem QA]

Attachment: NoSavedLogins_Sync.mp4

[Affected versions]:

• Firefox latest Nightly 71.0a1 (Build ID: 20191009213914) (64-bit)

[Affected Platforms]:

• Mac 10.14
• Windows 10 x64
• Ubuntu 16.04 x64

[Prerequisites]:

• Have a new Firefox profile.
• Have a valid Firefox Account with multiple logins saved.

[Steps to reproduce]:

1. Open the browser with the profile from prerequisites.
2. Navigate to the "about:logins" page.
3. Click on the “Sign in to Sync” button.
4. Enter the credentials from the prerequisites and log in.
5. Go back to the “about:logins” page and observe the “Login List”.

[Expected result]:

• The saved logins are successfully synchronized and displayed in the “Login List”.

[Actual result]:

• The saved logins are not synchronized.

[Regression]

• The issue is not reproducible with older Nightly 70.0a1 builds. Considering this, using mozregression tool I have found the issue that broke this in the latest Nightly build. Here are the results:
• Pushlog: https://tinyurl.com/y2n76ws3
• Last good revision: 388dbc366e53877fea8728a12ff568d587f73d5a
• First bad revision: 5f00644587653baf160b72877bea0d58e3d1a3be

From this pushlog it seems that bug 1577690 introduced this behavior.

[Notes]:

• Attached a screen recording with the issue.

Comment 1

[Simona Rosu [:srosu], Ecosystem QA]

@Matt, could you please take a look over this issue?

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Comment #0 says "Firefox latest Nightly 70.0a1 (Build ID: 20191009213914) (64-bit)". Shouldn't that be 71.0a1?

Comment 3

[Edouard Oger [:eoger]]

If you sync manually do you get the logins list?

Comment 4

[Edouard Oger [:eoger]]

I believe it should be fixed by bug 1587691, can you have a look after it lands?

Comment 5

[Simona Rosu [:srosu], Ecosystem QA]

@Jared, sorry for this inconvenience. I’ve updated the bug description with the correct version.

Comment 6

[Simona Rosu [:srosu], Ecosystem QA]

@Edouard, it seems that bug 1587450 might introduced this behavior and sync is no longer enabled when logging in with an existent account on latest Firefox Nightly 71.0a1.

Comment 7

[Jared Wein [:jaws] (please needinfo? me)]

Edouard, can you look deeper in to this?

Comment 8

[Edouard Oger [:eoger]]

Waiting on https://github.com/mozilla/fxa/pull/2817 to get deployed (should be today).

Comment 9

[Matthew N. [:MattN]]

This may be fixed already but I'll let someone on the Sync team confirm.

Comment 10

[Mark Hammond [:markh] [:mhammond]]

All the pieces from bug 1587450 have landed, so signing in with an existing account now again enables sync by default.

Simona, could you please verify and close this bug?

Comment 11

[Ciprian Muresan [:cmuresan], Ecosystem QA]

Marking this as RESOLVED - FIXED based on comment 10.

Comment 12

[Ciprian Muresan [:cmuresan], Ecosystem QA]

Updated the status flag.

Comment 13

[Simona Rosu [:srosu], Ecosystem QA]

I have verified this issue on the latest Nightly 71.0a1 (Build ID: 20191013213650) on Windows 10 x64, Mac 10.14, Ubuntu 16 x64.

• The saved logins are correctly displayed in the “Login List” from “about:logins” page after signing in to Sync.

Comment 14

[aztecjoe]

Hi I have this same/similar issue. I'm using 78.0.2 on 16.04 64bit.
snap list | grep firefox
firefox 78.0.2-2 392 latest/stable mozilla* -
There is an error log when sync(ing) from about:sync-log (cat error.log | grep password
1594874093270 Sync.Engine.Passwords DEBUG Resetting passwords last sync time
1594874093294 Sync.Service INFO Testing info/collections: {"crypto":1588908847.53,"passwords":1594872704.01,"meta":1594556229.94,"prefs":1594872707,"tabs":1594873938.85,"bookmarks":1594872705.06,"clients":1594873938.57}
1594874094293 Sync.Service INFO Testing info/collections: {"meta":1594556229.94,"tabs":1594873938.85,"passwords":1594872704.01,"clients":1594873938.57,"prefs":1594872707,"bookmarks":1594872705.06,"crypto":1588908847.53}
1594874094792 Sync.Service INFO Testing info/collections: {"prefs":1594872707,"passwords":1594872704.01,"clients":1594873938.57,"bookmarks":1594872705.06,"crypto":1588908847.53,"tabs":1594873938.85,"meta":1594556229.94}
1594874095370 Sync.Engine.Passwords DEBUG Resetting passwords last sync time
1594874095669 Sync.Engine.Passwords DEBUG Engine syncIDs: HTgOm9r430yh,
1594874095670 Sync.Engine.Passwords DEBUG First sync, uploading all items
1594874095810 Sync.Engine.Passwords INFO 259 outgoing items pre-reconciliation
1594874096281 Sync.Collection DEBUG GET success 200 https://sync-1-us-west1-g.sync.services.mozilla.com/1.5/152473514/storage/passwords?full=1&limit=1000
1594874096761 Sync.Engine.Passwords INFO Records: 0 applied, 0 successfully, 0 failed to apply, 0 newly failed to apply, 280 reconciled.
1594874096762 Sync.Engine.Passwords INFO Posting 1 records of 207 bytes with batch=true
1594874097094 Sync.Collection DEBUG POST success 200 https://sync-1-us-west1-g.sync.services.mozilla.com/1.5/152473514/storage/passwords?batch=true&commit=true
1594874097362 Sync.Collection DEBUG DELETE success 200 https://sync-1-us-west1-g.sync.services.mozilla.com/1.5/152473514/storage/passwords?ids={498e391e-1e8a-45a9-8841-cf110f72fa82}
1594874097362 Sync.Engine.Passwords DEBUG Delete result: [object Object]
1594874098174 Sync.Doctor INFO Skipping check of passwords - disabled via preferences

Apologies for verbose output.

Comment 15

[Mark Hammond [:markh] [:mhammond]]

(In reply to aztecjoe from comment #14)

Hi I have this same/similar issue. I'm using 78.0.2 on 16.04 64bit.

Please open a new bug, explaining what symptoms you are seeing exactly (for example, just from the snapshot you have it appears as though you have around 280 passwords locally, so we need to know exactly what is and isn't working for you).

Comment 16

[aztecjoe]

Done Bug 1653472