Closed Bug 1587767 Opened 4 years ago Closed 4 years ago

Assert link flag handling in NodeInfoChanged is correct.

Categories

(Core :: DOM: Core & HTML, task)

Product:
Core
Component:
DOM: Core & HTML
Type:
task
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla71
Tracking Flags:
Tracking Status
firefox71 --- fixed

People

(Reporter: emilio, Assigned: emilio)

Details

Attachments

(1 file)

Bug 1587767 - Assert that link flag handling is correct, and that NodeInfoChanged is only called on disconnected nodes.
47 bytes, text/x-phabricator-request
Details | Review
No description provided.

It's trying to clear a flag that can only be set on connected nodes.

Clean up the code by removing it and the relevant overrides, and assert in
Element that these invariants hold.

Attachment #9100147 - Attachment description: Bug 1587767 - Link::NodeInfoChanged seems useless. → Bug 1587767 - Assert that link flag handling is correct, and that NodeInfoChanged is only called on disconnected nodes.
Summary: Link::NodeInfoChanged looks useless. → Assert link flag handling in NodeInfoChanged is correct.
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/db60f0e2c246
Assert that link flag handling is correct, and that NodeInfoChanged is only called on disconnected nodes. r=smaug
Type: defect → task

https://hg.mozilla.org/mozilla-central/rev/db60f0e2c246

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox71: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
You need to log in before you can comment on or make changes to this bug.