[wpt-sync] Sync PR 19619 - Clear the current interval when no more intervals can be resolved
Categories
(Core :: SVG, task, P4)
Tracking
()
Tracking | Status | |
---|---|---|
firefox72 | --- | fixed |
People
(Reporter: mozilla.org, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 19619 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/19619
Details from upstream follow.
Fredrik Söderquist <fs@opera.com> wrote:
Clear the current interval when no more intervals can be resolved
When no more intervals can be resolved, ResolveInterval(...) will return
an interval that return false from IsResolved() (meaning it has no
finite begin time). When this happens we should "clear" |interval_| by
setting it to an unresolved interval.This fixes the behavior of SVGAnimationElement.getStartTime() which now
correctly report (throws) when the last interval of element has ended.
Add a new test for that and move an old somewhat related test to WPT.
Also adjust SVGAnimationTestCase.js which uses this to offset the sample
times (although in most cases) to avoid the debug dump when there's no
current interval (no tests actually rely on the old broken behavior).This makes us match Firefox.
Bug: 998526
Change-Id: Idcf348343768ffc9392e29af2e976b9a3a1e31aa
Reviewed-on: https://chromium-review.googlesource.com/1849897
WPT-Export-Revision: d84ecf3bce97e89fa6a0f83cf02c7c678ff00058
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Comment 1•5 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=67c31dc21fe3662bc6a959140310a7e9f15cf5ea
Assignee | ||
Comment 2•5 years ago
|
||
## GitHub CI Results wpt.fyi [PR Results](https://wpt.fyi/results/?sha=70cea542875356e9406fc9cb911bfab8f074c2e9&label=pr_head) [Base Results](https://wpt.fyi/results/?sha=70cea542875356e9406fc9cb911bfab8f074c2e9&label=pr_base) Ran 2 tests and 3 subtests ### Firefox OK : 2 PASS: 3 ### Chrome OK : 2 PASS: 2 FAIL: 1 ### Safari OK : 2 FAIL: 3 ## Gecko CI Results Ran 2 tests and 3 subtests OK : 2 PASS : 3
Pushed by james@hoppipolla.co.uk: https://hg.mozilla.org/integration/mozilla-inbound/rev/f98a9282e2fe [wpt PR 19619] - Clear the current interval when no more intervals can be resolved, a=testonly
Comment 4•5 years ago
|
||
bugherder |
Description
•