1587803 - Check BrowserContentHandler.jsm doSearch uses the right engine

Status: RESOLVED FIXED

(Firefox :: Search, defect, P3)

Description

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

the command line handler in BrowserContentHandler.jsm may open a new window to search, we must ensure that either it never opens a PB window, or if it does, it uses the private engine.

Comment 1

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

These are the cases where I could run a search in pb mode from the command line:
./mach run -private "? test"
./mach run -private -search "test"
After enabling permanent pb mode:
./mach run "? test"
./mach run -search "test"

the -private-window URL command doesn't seem to be able to execute a search in the private window, it always boils down to a fixed uri.

Comment 2

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Attachment: Bug 1587803 - Check BrowserContentHandler.jsm::doSearch() uses the private engine when appropriate. r=Standard8

Comment 3

[Mark Banner (:standard8)]

(In reply to Marco Bonardo [::mak] from comment #1)

These are the cases where I could run a search in pb mode from the command line:
./mach run -private "? test"
./mach run -private -search "test"
./mach run "? test"

Interesting, none of these work on Mac.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/06644c68c7e7
Check BrowserContentHandler.jsm::doSearch() uses the private engine when appropriate. r=Standard8

Comment 5

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

the "? keyword" are expected to only work on Windows anyway, they exist for compatibility with the OS search in Windows 7, at least.

Comment 6

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/06644c68c7e7