1587814 - Massive memory leaks when running Puppeteer unit tests

Status: REOPENED

(Remote Protocol :: Agent, defect, P3)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Leak report

Running the puppeteer unit tests results in a lot of leaks. See the list of components from the attached log.

There will be several dependent bugs before we will have all this fixed.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

This is actually a problem with Puppeteer itself. For each test a new instance of the Page domain is created, which also means Network.enable is called. There is no destructor code which would call Network.disable, and it means that all registered events and observer notifications from the Network domain are leaked.

I filed https://github.com/GoogleChrome/puppeteer/issues/5043 for that.

It also means that we cannot do much about it yet, and have to wait until it has been fixed in Puppeteer.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The meta keyword is there, the bug doesn't depend on other bugs and there is no activity for 12 months.
:whimboo, maybe it's time to close this bug?

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

I checked again with a local debug build. Nothing obvious is visible anymore. Maybe the move to Typescript somewhat fixed it?

As such I'm going to close this bug.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Err, running the mach command locally doesn't seem to fail when there are leaks. As such I didn't notice them.

Lots of them are still present so I'll reopen the bug, and handle it as a non-meta for now.