Closed Bug 1587819 Opened Last month Closed 29 days ago

[HTMLConstructor] should be an extended attribute on constructor operations

Categories

(Core :: DOM: Bindings (WebIDL), task, P1)

task

Tracking

()

RESOLVED FIXED
mozilla71
Tracking Status
firefox71 --- fixed

People

(Reporter: saschanaz, Assigned: bzbarsky)

References

Details

Attachments

(1 file)

Currently it's for interfaces but per the updated spec it now must be used for constructors. Just a syntax change without any observable behavior difference.

Depends on: 1578173
Priority: -- → P1
Summary: Convert [HTMLConstructor] as an extattr for `constructor()` → [HTMLConstructor] should be an extended attribute on constructor operations

The changes to the IDL files were done by running this in dom/webidl:

perl -pi -e 'BEGIN { $/ = undef; } s/[HTMLConstructor,\n Exposed=Window]\ninterface ([A-Za-z]+) : HTMLElement {/[Exposed=Window]\ninterface \1 : HTMLElement{\n [HTMLConstructor] constructor();\n/g' *.webidl

and then fixing any remaining parser failures. That involved hand-editing the
following files:

TestCodeGen.webidl
XULFrameElement.webidl
XULMenuElement.webidl
XULTextElement.webidl
XULTreeElement.webidl
HTMLAudioElement.webidl
HTMLDialogElement.webidl
HTMLElement.webidl
HTMLEmbedElement.webidl
HTMLFormElement.webidl
HTMLImageElement.webidl
HTMLObjectElement.webidl
HTMLOptionElement.webidl
HTMLSlotElement.webidl
HTMLVideoElement.webidl
XULElement.webidl
XULPopupElement.webidl

Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b8905d33a7c0
Convert [HTMLConstructor] to being an extended attribute on constructor operations.  r=edgar
Status: NEW → RESOLVED
Closed: 29 days ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
Assignee: nobody → bzbarsky
You need to log in before you can comment on or make changes to this bug.