Closed Bug 1587907 Opened 5 years ago Closed 5 years ago

Intermittent tools/profiler/tests/browser/browser_test_profile_single_frame_page_info.js | Uncaught exception - at chrome://mochitests/content/browser/tools/profiler/tests/browser/browser_test_profile_single_frame_page_info.js:30 - TypeError: contentProce

Categories

(Core :: Gecko Profiler, defect, P3)

Product:
Core
Component:
Gecko Profiler
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla72
Tracking Flags:
Tracking Status
firefox71 --- fixed
firefox72 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: canova)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

Bug 1587907 - Move test content inside the BrowserTestUtils.withNewTab function callback r?gregtatum
47 bytes, text/x-phabricator-request
Details | Review

Filed by: rmaries [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=270735756&repo=mozilla-central
Full log: https://queue.taskcluster.net/v1/task/XnGwKp_XT-uF6lctAIt-kQ/runs/0/artifacts/public/logs/live_backing.log

[task 2019-10-10T18:13:01.747Z] 18:13:01 INFO - TEST-START | tools/profiler/tests/browser/browser_test_profile_single_frame_page_info.js
[task 2019-10-10T18:13:02.177Z] 18:13:02 INFO - GECKO(9636) | [Parent 9348, Gecko_IOThread] WARNING: pipe error: 109: file z:/build/build/src/ipc/chromium/src/chrome/common/ipc_channel_win.cc, line 341
[task 2019-10-10T18:13:02.195Z] 18:13:02 INFO - GECKO(9636) | ###!!! [Parent][RunMessage] Error: Channel closing: too late to send/recv, messages will be lost
[task 2019-10-10T18:13:02.195Z] 18:13:02 INFO - GECKO(9636) | [Child 6252, Chrome_ChildThread] WARNING: pipe error: 109: file z:/build/build/src/ipc/chromium/src/chrome/common/ipc_channel_win.cc, line 341
[task 2019-10-10T18:13:02.195Z] 18:13:02 INFO - GECKO(9636) | [Child 6252, Chrome_ChildThread] WARNING: pipe error: 109: file z:/build/build/src/ipc/chromium/src/chrome/common/ipc_channel_win.cc, line 341
[task 2019-10-10T18:13:02.214Z] 18:13:02 INFO - TEST-INFO | started process screenshot
[task 2019-10-10T18:13:02.273Z] 18:13:02 INFO - TEST-INFO | screenshot: exit 0
[task 2019-10-10T18:13:02.273Z] 18:13:02 INFO - Buffered messages logged at 18:13:01
[task 2019-10-10T18:13:02.273Z] 18:13:02 INFO - Entering test bound test_profile_single_frame_page_info
[task 2019-10-10T18:13:02.273Z] 18:13:02 INFO - TEST-PASS | tools/profiler/tests/browser/browser_test_profile_single_frame_page_info.js | true == true -
[task 2019-10-10T18:13:02.274Z] 18:13:02 INFO - Buffered messages finished
[task 2019-10-10T18:13:02.274Z] 18:13:02 INFO - TEST-UNEXPECTED-FAIL | tools/profiler/tests/browser/browser_test_profile_single_frame_page_info.js | Uncaught exception - at chrome://mochitests/content/browser/tools/profiler/tests/browser/browser_test_profile_single_frame_page_info.js:30 - TypeError: contentProcess is undefined
[task 2019-10-10T18:13:02.274Z] 18:13:02 INFO - Stack trace:
[task 2019-10-10T18:13:02.274Z] 18:13:02 INFO - test_profile_single_frame_page_info@chrome://mochitests/content/browser/tools/profiler/tests/browser/browser_test_profile_single_frame_page_info.js:30:22
[task 2019-10-10T18:13:02.274Z] 18:13:02 INFO - Async*Tester_execTest/<@chrome://mochikit/content/browser-test.js:1345:34
[task 2019-10-10T18:13:02.274Z] 18:13:02 INFO - Tester_execTest@chrome://mochikit/content/browser-test.js:1380:11
[task 2019-10-10T18:13:02.274Z] 18:13:02 INFO - nextTest/<@chrome://mochikit/content/browser-test.js:1208:14
[task 2019-10-10T18:13:02.275Z] 18:13:02 INFO - SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:805:67
[task 2019-10-10T18:13:02.275Z] 18:13:02 INFO - Leaving test bound test_profile_single_frame_page_info
[task 2019-10-10T18:13:02.276Z] 18:13:02 INFO - GECKO(9636) | MEMORY STAT | vsize 2104152MB | vsizeMaxContiguous 65650737MB | residentFast 300MB | heapAllocated 129MB
[task 2019-10-10T18:13:02.276Z] 18:13:02 INFO - TEST-OK | tools/profiler/tests/browser/browser_test_profile_single_frame_page_info.js | took 483ms
[task 2019-10-10T18:13:02.276Z] 18:13:02 INFO - checking window state
[task 2019-10-10T18:13:03.790Z] 18:13:03 INFO - GECKO(9636) | Completed ShutdownLeaks collections in process 10180
[task 2019-10-10T18:13:03.828Z] 18:13:03 INFO - GECKO(9636) | Completed ShutdownLeaks collections in process 1724
[task 2019-10-10T18:13:03.828Z] 18:13:03 INFO - GECKO(9636) | Completed ShutdownLeaks collections in process 1308
[task 2019-10-10T18:13:03.833Z] 18:13:03 INFO - GECKO(9636) | Completed ShutdownLeaks collections in process 8196
[task 2019-10-10T18:13:03.833Z] 18:13:03 INFO - GECKO(9636) | Completed ShutdownLeaks collections in process 10860
[task 2019-10-10T18:13:03.835Z] 18:13:03 INFO - GECKO(9636) | Completed ShutdownLeaks collections in process 10788
[task 2019-10-10T18:13:03.837Z] 18:13:03 INFO - GECKO(9636) | Completed ShutdownLeaks collections in process 9492
[task 2019-10-10T18:13:03.847Z] 18:13:03 INFO - GECKO(9636) | Completed ShutdownLeaks collections in process 8692
[task 2019-10-10T18:13:04.635Z] 18:13:04 INFO - GECKO(9636) | Completed ShutdownLeaks collections in process 9348

Nazim, could that be due to bug 1583271 or bug 1512500?

Flags: needinfo?(canaltinova)
Priority: P5 → P1

Hm, I didn't change that part of the test. This is throwing error because this code part is returning find function is returning undefined: https://searchfox.org/mozilla-central/rev/5e830ac8f56fe191cb58a264e01cdbf6b6e847bd/tools/profiler/tests/browser/browser_test_profile_single_frame_page_info.js#27-29 Specifically this code:

let contentProcess = profile.processes.find(
  p => p.threads[0].pid == contentPid
);

This means that we are failing to get content process pid. That can be because either contentPid is undefined or we fail to get profile from that content process. It seems like these page information bugs are not related to that issue. Also there was Bug 1586105 before which is an intermittent failure because the test takes too long. I'm assuming this error might also happen because the timeout threshold is passed for this test and test is stopped in the middle? I was hoping that it's gonna be fixed but apparently not.

Will do some test-verify runs to understand it a bit more. Keeping the needinfo for now.

Seems low-frequency -> P3.
(I will monitor all recent intermittents.)

Priority: P1 → P3

In Bug 1587907 we got some contentPid not found errors. It seemed like we were
failing intermittently at getting content pid. After moving test content inside
the BrowserTestUtils.withNewTab callback, we won't get the same error anymore.
Also from my testing, it looks like it makes the test execution faster. We were
getting some intermittents before because of the timeouts, these will be fixed
if my testing is correct.

We were also having some intermittents for this test(See bug 1586105). I believe that this patch will fix both of them. Previously, the test case was outside of BrowserTestUtils.withNewTab callback, and I think it's intermittently failing to get the content pid and we were failing at the testing part. Now I moved everything iniside the callback and did lots of testing, it looks like it's good now.

Flags: needinfo?(canaltinova)
Pushed by canaltinova@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/d739b932e308
Move test content inside the BrowserTestUtils.withNewTab function callback r=gregtatum

https://hg.mozilla.org/mozilla-central/rev/d739b932e308

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox72: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
Assignee: nobody → canaltinova
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: