158792 - click-select-node no longer works; tree view not updated on URL loads

Status: RESOLVED FIXED

(Other Applications :: DOM Inspector, defect)

Description

[Boris Zbarsky [:bzbarsky]]

This is a regression from the fix for bug 156072.  Backing out the dom.js change
fixes it.

There are two problems:

1)  The "Find a node to inspect by clicking on it" functionality does not work
2)  Typing a url in the urlbar (in inspector) and hitting enter does not update
    the top-left DOM tree view immediately.  It ends up waiting on some event or
    something...

There are no errors in the JS console.

Comment 1

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Attachment: screenshot of weird behaviour

another strange thing is that clicking the document node opens a DOM-inspector
in the "nodeinfo-pane". Kind'a hard to describe, have a look at the screenshot

Comment 2

[Boris Zbarsky [:bzbarsky]]

jst says this may be due to some code somewhere QIing to nsIContent; documents
implement nsIDOMNode but not nsIContent....

Comment 3

[Boris Zbarsky [:bzbarsky]]

*** Bug 159079 has been marked as a duplicate of this bug. ***

Comment 4

[Boris Zbarsky [:bzbarsky]]

Attachment: This is the tip of the iceberg

So.... we need to call selectElementInTree on the right thing in
setInitialSelection().	This fixes the "can't click-select" and "view not
updated" issues.  _However_, when this is done the problem sicking noticed
kicks in....  The live tree is on the _right_, not on the left.  That's not so
great.	No idea yet why that's happening.

A further issue is that even with this patch, if the #document node's twisty is
collapsed and then we try to do click-to-select things break.  The reason is
that inDeepTreeWalker::ParentNode effectively skips over the #document node and
runs up into XUL while looking for the tree root.  This could be fixed by
either hacking ParentNode() to somehow recognize that it has come to the root
of the view _or_ by showing #document nodes as children of iframes and then
having ParentNode() only jump for a _document_, not a documentElement.	So the
display would be something like:

#document
  <?pi?>
  HTML
    BODY
      IFRAME
	#document
	  <?pi?>
	  HTML
	    BODY

Thoughts on that?

We need to either fix this by a day or two from now or back out the dom.js
changes from bug 156072; shipping 1.1 like this is unacceptable.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Attachment: backout patch

Comment 6

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 92800 [details] [diff] [review]
backout patch

this has r=caillon, rs=jst

Comment 7

[Asa Dotzler [:asa]]

Comment on attachment 92800 [details] [diff] [review]
backout patch

a=asa (on behalf of drivers) for checkin to 1.1

Comment 8

[Boris Zbarsky [:bzbarsky]]

fixed