Closed Bug 1587989 Opened 3 years ago Closed 2 years ago

[wpt-sync] Sync PR 19634 - Enable Scroll To Text by default

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox74 fixed)

RESOLVED FIXED
mozilla74
Tracking Status
firefox74 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 19634 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/19634
Details from upstream follow.

Nick Burris <nburris@chromium.org> wrote:

Enable Scroll To Text by default

Kick off the rollout of Scroll To Text for M79, pending the intent to
ship.

Bug: 919204
Change-Id: Ic2d563934cd9406fb335904a94c390bba789e0b4
Reviewed-on: https://chromium-review.googlesource.com/1838701
WPT-Export-Revision: 5091d4a38599710a84745a5fffe1166836490e92

CI Results

Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 43 tests

Status Summary

Firefox

OK : 2
PASS : 1[GitHub] 42[Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-asan-opt, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt]
FAIL : 42

Chrome

PASS : 1
FAIL : 14
TIMEOUT: 4
NOTRUN : 26

Safari

PASS : 1
FAIL : 2
TIMEOUT: 4
NOTRUN : 38

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/scroll-to-text-fragment/scroll-to-text-fragment.html
Test navigation with fragment: Fragment directive with percent encoded syntactical characters "&,-" should match text.: FAIL (Chrome: NOTRUN, Safari: NOTRUN)
Test navigation with fragment: Non-matching text directive with existing element fragment should scroll to element.: FAIL (Chrome: NOTRUN, Safari: NOTRUN)
Test navigation with fragment: Generic fragment directive with existing element fragment should scroll to element.: FAIL (Chrome: FAIL, Safari: NOTRUN)
Test navigation with fragment: Exact text with prefix should match text.: FAIL (Chrome: FAIL, Safari: NOTRUN)
Test navigation with fragment: Multiple match text directive disambiguated by suffix should match the suffixed text.: FAIL (Chrome: NOTRUN, Safari: NOTRUN)
Test navigation with fragment: Exact text with suffix should match text.: FAIL (Chrome: FAIL, Safari: NOTRUN)
Test navigation with fragment: Text directive should match when context terms are separated by node boundaries.: FAIL (Chrome: NOTRUN, Safari: NOTRUN)
Test navigation with fragment: Non-matching text directive with nonexistent element fragment should not match and not scroll.: FAIL (Chrome: NOTRUN, Safari: NOTRUN)
Test navigation with fragment: Non-whole-word exact text with spaces should not match.: FAIL (Chrome: NOTRUN, Safari: NOTRUN)
Test navigation with fragment: Text range with prefix and suffix should match text.: FAIL (Chrome: FAIL, Safari: NOTRUN)
Test navigation with fragment: Text directive should not scroll to hidden text.: FAIL (Chrome: NOTRUN, Safari: NOTRUN)
Test navigation with fragment: Multiple match text directive disambiguated by prefix should match the prefixed text.: FAIL (Chrome: NOTRUN, Safari: NOTRUN)
Test navigation with fragment: Text range with no context should match text.: FAIL (Chrome: FAIL, Safari: NOTRUN)
Test navigation with fragment: Text range with prefix and nonmatching suffix should not match.: FAIL (Chrome: NOTRUN, Safari: NOTRUN)
Test navigation with fragment: Multiple non-whole-word exact texts should not match.: FAIL (Chrome: NOTRUN, Safari: NOTRUN)
Test navigation with fragment: Multiple text directives and a non-text directive should match text.: FAIL (Chrome: NOTRUN, Safari: NOTRUN)
Test navigation with fragment: Text directive should match text within shadow DOM.: FAIL (Chrome: NOTRUN, Safari: NOTRUN)
Test navigation with fragment: Text range with non-matching startText should not match.: FAIL (Chrome: NOTRUN, Safari: NOTRUN)
Test navigation with fragment: Text directive with invalid syntax (context terms without "-") should not parse as a text directive.: FAIL (Chrome: FAIL, Safari: TIMEOUT)
Test navigation with fragment: Text directive with existing element fragment should match and scroll into view text.: FAIL (Chrome: NOTRUN, Safari: NOTRUN)
Test navigation with fragment: Multiple match text directive disambiguated by prefix and suffix should match the text with the given context.: FAIL (Chrome: NOTRUN, Safari: NOTRUN)
Test navigation with fragment: Text range with non-matching endText should not match.: FAIL (Chrome: TIMEOUT, Safari: NOTRUN)
Test navigation with fragment: Text range with prefix should match text.: FAIL (Chrome: FAIL, Safari: NOTRUN)
Test navigation with fragment: Text range with suffix should match text.: FAIL (Chrome: FAIL, Safari: NOTRUN)
Test navigation with fragment: Text directive with nonexistent element fragment should match and scroll into view text.: FAIL (Chrome: NOTRUN, Safari: NOTRUN)
Test navigation with fragment: Text range with nonmatching prefix and matching suffix should not match.: FAIL (Chrome: NOTRUN, Safari: NOTRUN)
Test navigation with fragment: Exact text with prefix and suffix should match text.: FAIL (Chrome: FAIL, Safari: NOTRUN)
Test navigation with fragment: Fragment directive with all TextMatchChars should match text.: FAIL (Chrome: NOTRUN, Safari: NOTRUN)
Test navigation with fragment: Exact text with percent encoded spaces should match text.: FAIL (Chrome: NOTRUN, Safari: NOTRUN)
Test navigation with fragment: A non-matching text directive followed by a matching text directive should match and scroll into view the second text directive.: FAIL (Chrome: NOTRUN, Safari: NOTRUN)
Test navigation with fragment: Text directive should not scroll to display none text.: FAIL (Chrome: NOTRUN, Safari: NOTRUN)
Test navigation with fragment: Uppercase TEXT directive should not parse as a text directive.: FAIL (Chrome: FAIL, Safari: NOTRUN)
Test navigation with fragment: Multiple matching exact texts should match text.: FAIL (Chrome: NOTRUN, Safari: NOTRUN)
Test navigation with fragment: Fragment directive with percent encoded non-ASCII unicode character should match text.: FAIL (Chrome: NOTRUN, Safari: NOTRUN)
Test navigation with fragment: Exact text with no context should match text.: FAIL (Chrome: FAIL, Safari: NOTRUN)
Test navigation with fragment: Text directive should horizontally scroll into view.: FAIL (Chrome: NOTRUN, Safari: NOTRUN)
Test navigation with fragment: Text directive followed by non-text directive should match text.: FAIL (Chrome: NOTRUN, Safari: NOTRUN)
/scroll-to-text-fragment/scroll-to-text-fragment-security.html
Test that a text fragment directive requires a user activation (user_activation=false).: FAIL (Chrome: FAIL, Safari: FAIL)
Test that a text fragment directive is not activated within an iframe.: FAIL (Chrome: NOTRUN, Safari: NOTRUN)
Test that a text fragment directive requires a user activation (user_activation=true).: FAIL (Chrome: FAIL, Safari: FAIL)
Test that a text fragment directive is not activated when there is a window opener (noopener=true).: FAIL (Chrome: FAIL, Safari: TIMEOUT)
Test that a text fragment directive is not activated when there is a window opener (noopener=false).: FAIL (Chrome: TIMEOUT, Safari: NOTRUN)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9e159341d88b
[wpt PR 19634] - Enable Scroll To Text by default, a=testonly
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla74
You need to log in before you can comment on or make changes to this bug.