1588002 - Make sure to remove the wakelock listener in browser_media_wakelock.js in cases where the callback is never called

Status: RESOLVED FIXED

(Toolkit :: General, task, P2)

Description

[Mike Conley (:mconley) (:⚙️)]

getWakeLockState inside of browser_media_wakelock.js adds a nsIDOMMozWakeLockListener to listen for wake lock notifications for the test.

It looks, however, like the listener is only ever removed when a notification is seen. In more than one case, it looks like a listener is added when a notification is not expected, so that listener is never removed.

I don't know why this wasn't leaking for the non-Fission case, but it was definitely causing a leak-the-world leak with Fission enabled.

I've modified the test so that in the event that the notification was not expected, we still remove the listener.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1588002 - Make sure to remove every nsIDOMMozWakeLockListener added by browser_media_wakelock.js even if a notification is not seen. r?alwu

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6b0a3059d313
Make sure to remove every nsIDOMMozWakeLockListener added by browser_media_wakelock.js even if a notification is not seen. r=alwu

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/6b0a3059d313