Closed Bug 1588055 Opened 9 months ago Closed 8 months ago

Clear MediaPipeline static-analysis warnings

Categories

(Core :: WebRTC: Audio/Video, task, P3)

task

Tracking

()

RESOLVED FIXED
mozilla72
Tracking Status
firefox72 --- fixed

People

(Reporter: pehrsons, Assigned: pehrsons)

Details

Attachments

(2 files)

This traverses through to TransceiverImpl and fixes a bug, where an nsAutoPtr
was copied twice. Because nsAutoPtr semantics are bad, a copy really means move,
and so the second copy would always be copying a nullptr.

Having changed this to UniquePtr, we now have to manually make a copy instead.
As it should be.

Depends on D48957

There are some r+ patches which didn't land and no activity in this bug for 2 weeks.
:pehrsons, could you have a look please?
For more information, please visit auto_nag documentation.

Flags: needinfo?(apehrson)
Flags: needinfo?(apehrson)
Pushed by pehrsons@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/bbff556beb57
Fix MediaPipeline static-analysis warnings and make RefPtr passing consistent. r=bwc
https://hg.mozilla.org/integration/autoland/rev/15f2829db807
Remove use of nsAutoPtr in MediaPipeline. r=bwc
Pushed by pehrsons@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/b28a24fa2076
Fix MediaPipeline static-analysis warnings and make RefPtr passing consistent. r=bwc
https://hg.mozilla.org/integration/autoland/rev/c4f2a7e9107a
Remove use of nsAutoPtr in MediaPipeline. r=bwc
Status: ASSIGNED → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
You need to log in before you can comment on or make changes to this bug.