Closed Bug 1588056 Opened 10 months ago Closed 6 months ago

Telemetry about an effect of coalescing network change events

Categories

(Core :: Networking: HTTP, enhancement, P2)

enhancement

Tracking

()

RESOLVED WONTFIX

People

(Reporter: dragana, Assigned: dragana)

Details

(Whiteboard: [necko-triaged])

Attachments

(1 file, 1 obsolete file)

No description provided.
Attached file request1588056.md
Attachment #9100420 - Flags: data-review?(chutten)
Keywords: checkin-needed

data review is not done, sorry.

Keywords: checkin-needed
Comment on attachment 9100420 [details]
request1588056.md

DATA COLLECTION REVIEW RESPONSE:

    Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes. This collection is Telemetry so is documented in its definitions file [Histograms.json](https://hg.mozilla.org/mozilla-central/file/tip/toolkit/components/telemetry/Histograms.json) and the [Probe Dictionary](https://telemetry.mozilla.org/probe-dictionary/).

    Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection is Telemetry so can be controlled through Firefox's Preferences.

    If the request is for permanent data collection, is there someone who will monitor the data over time?

No. This collection will expire in Firefox 72.

    Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 1, Technical.

    Is the data collection request for default-on or default-off?

Default on for all channels.

    Does the instrumentation include the addition of any new identifiers?

No.

    Is the data collection covered by the existing Firefox privacy notice?

Yes.

    Does there need to be a check-in in the future to determine whether to renew the data?

Yes. Dragana is responsible for renewing or removing the collection before it expires in Firefox 72.

---
Result: datareview+
Attachment #9100420 - Flags: data-review?(chutten) → data-review+
Keywords: checkin-needed

Pushed by rmaries@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/61a42130beb8
Add telemetry about the time between network change events if we do the events coalescing. r=valentin

Keywords: checkin-needed

Land failed:

Details: We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again. applying /tmp/tmprx8izN netwerk/system/mac/nsNetworkLinkService.h Hunk #1 FAILED at 57. 1 out of 1 hunk FAILED -- saving rejects to file netwerk/system/mac/nsNetworkLinkService.h.rej abort: patch command failed: exited with status 256

Flags: needinfo?(dd.mozilla)

Sorry.
Rebased.

Flags: needinfo?(dd.mozilla)
Pushed by btara@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0961f4328316
Add telemetry about the time between network change events if we do the events coalescing. r=valentin

Backed out changeset 0961f4328316 (bug 1588056) for build bustage at nsNetworkLinkService.mm on a CLOSED TREE.

Backout link: https://hg.mozilla.org/integration/autoland/rev/1eb6ecbc50dbdd57e153c3e969ed27bbc43fed06

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=0961f4328316fb6ca5a63ef3bca80a4b79477d93&selectedJob=273564593

Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=273564593&repo=autoland&lineNumber=13587

Log snippet:
[task 2019-10-29T22:39:05.398Z] 22:39:05 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/netwerk/protocol/http'
[task 2019-10-29T22:39:05.697Z] 22:39:05 INFO - make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/netwerk/system/mac'
[task 2019-10-29T22:39:05.697Z] 22:39:05 INFO - netwerk/system/mac/nsNetworkLinkService.o
[task 2019-10-29T22:39:05.698Z] 22:39:05 INFO - /builds/worker/fetches/sccache/sccache /builds/worker/fetches/clang/bin/clang++ -isysroot /builds/worker/workspace/build/src/MacOSX10.11.sdk --target=x86_64-apple-darwin -o nsNetworkLinkService.o -c -fvisibility=hidden -fvisibility-inlines-hidden -DNDEBUG=1 -DTRIMMED=1 -DSTATIC_EXPORTABLE_JS_API -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -I/builds/worker/workspace/build/src/netwerk/system/mac -I/builds/worker/workspace/build/src/obj-firefox/netwerk/system/mac -I/builds/worker/workspace/build/src/obj-firefox/dist/include -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nspr -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nss -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/build/src/obj-firefox/mozilla-config.h -Qunused-arguments -U_FORTIFY_SOURCE -fno-common -Qunused-arguments -Wall -Wbitfield-enum-conversion -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtype-limits -Wunreachable-code -Wunreachable-code-return -Wwrite-strings -Wno-invalid-offsetof -Wclass-varargs -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wc++1z-compat -Wc++2a-compat -Wcomma -Wimplicit-fallthrough -Werror=non-literal-null-conversion -Wstring-conversion -Wtautological-overlap-compare -Wtautological-unsigned-enum-zero-compare -Wtautological-unsigned-zero-compare -Wno-error=tautological-type-limit-compare -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=backend-plugin -Wno-error=return-std-move -Wno-error=atomic-alignment -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments -Wno-unknown-warning-option -Wno-return-type-c-linkage -fno-sized-deallocation -fno-aligned-new -fsanitize=address -fcrash-diagnostics-dir=/builds/worker/artifacts -fcrash-diagnostics-dir=/builds/worker/artifacts -U_FORTIFY_SOURCE -fno-common -fno-exceptions -fno-strict-aliasing -stdlib=libc++ -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -Xclang -load -Xclang /builds/worker/workspace/build/src/obj-firefox/build/clang-plugin/libclang-plugin.so -Xclang -add-plugin -Xclang moz-check -O2 -fno-omit-frame-pointer -funwind-tables -Werror -Wno-error=shadow -MD -MP -MF .deps/nsNetworkLinkService.o.pp -x objective-c++ -fobjc-exceptions /builds/worker/workspace/build/src/netwerk/system/mac/nsNetworkLinkService.mm
[task 2019-10-29T22:39:05.698Z] 22:39:05 ERROR - /builds/worker/workspace/build/src/netwerk/system/mac/nsNetworkLinkService.mm:654:51: error: no member named 'NETWORK_TIME_BETWEEN_NETWORK_CHANGE_EVENTS_5min' in namespace 'mozilla::Telemetry'; did you mean 'NETWORK_TIME_BETWEEN_NETWORK_CHANGE_EVENTS_5MIN'?
[task 2019-10-29T22:39:05.698Z] 22:39:05 INFO - Telemetry::AccumulateTimeDelta(Telemetry::NETWORK_TIME_BETWEEN_NETWORK_CHANGE_EVENTS_5min,
[task 2019-10-29T22:39:05.698Z] 22:39:05 INFO - ^
[task 2019-10-29T22:39:05.698Z] 22:39:05 INFO - NETWORK_TIME_BETWEEN_NETWORK_CHANGE_EVENTS_5MIN
[task 2019-10-29T22:39:05.698Z] 22:39:05 INFO - /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/TelemetryHistogramEnums.h:544:3: note: 'NETWORK_TIME_BETWEEN_NETWORK_CHANGE_EVENTS_5MIN' declared here
[task 2019-10-29T22:39:05.698Z] 22:39:05 INFO - NETWORK_TIME_BETWEEN_NETWORK_CHANGE_EVENTS_5MIN,
[task 2019-10-29T22:39:05.699Z] 22:39:05 INFO - ^
[task 2019-10-29T22:39:05.699Z] 22:39:05 INFO - 1 error generated.
[task 2019-10-29T22:39:05.699Z] 22:39:05 INFO - /builds/worker/workspace/build/src/config/rules.mk:792: recipe for target 'nsNetworkLinkService.o' failed
[task 2019-10-29T22:39:05.699Z] 22:39:05 ERROR - make[4]: *** [nsNetworkLinkService.o] Error 1
[task 2019-10-29T22:39:05.699Z] 22:39:05 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/netwerk/system/mac'
[task 2019-10-29T22:39:05.699Z] 22:39:05 INFO - /builds/worker/workspace/build/src/config/recurse.mk:74: recipe for target 'netwerk/system/mac/target-objects' failed
[task 2019-10-29T22:39:05.700Z] 22:39:05 ERROR - make[3]: *** [netwerk/system/mac/target-objects] Error 2
[task 2019-10-29T22:39:05.701Z] 22:39:05 INFO - make[3]: *** Waiting for unfinished jobs....
[task 2019-10-29T22:39:05.701Z] 22:39:05 INFO - make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/netwerk/base'
[task 2019-10-29T22:39:05.702Z] 22:39:05 INFO - netwerk/base/Unified_cpp_netwerk_base4.o

Flags: needinfo?(dd.mozilla)

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:dragana, could you have a look please?
For more information, please visit auto_nag documentation.

Flags: needinfo?(dd.mozilla)

we do not need this.

Status: ASSIGNED → RESOLVED
Closed: 6 months ago
Flags: needinfo?(dd.mozilla)
Resolution: --- → WONTFIX
Attachment #9100416 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.