Closed
Bug 1588057
Opened 5 years ago
Closed 5 years ago
Port bug 1578624: Adjust arguments of LoadURI
Categories
(MailNews Core :: General, defect)
MailNews Core
General
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 71.0
People
(Reporter: jorgk-bmo, Assigned: jorgk-bmo)
Details
Attachments
(2 files, 1 obsolete file)
1.97 KB,
patch
|
Details | Diff | Splinter Review | |
10.65 KB,
patch
|
benc
:
review+
|
Details | Diff | Splinter Review |
Assignee | ||
Comment 1•5 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/a3ba805d6d0cbbb2f958791a3bd2d9136f7ea67d#l4.17
I guess we'll pass false
.
Assignee | ||
Comment 3•5 years ago
|
||
Looks like some M-C stuff is broken, too :-(
Assignee | ||
Comment 4•5 years ago
|
||
Filed bug 1588065 for the M-C issue.
Assignee | ||
Comment 5•5 years ago
|
||
Here's a hacky workaround for the M-C issue. Just add the missing namespace before including the faulty include file. Compiles so far.
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/d7b26f4d5ea1
Port bug 1578624: Add 'set navigating' argument of nsIDocShell.loadURI() calls. Also hack namespace issue in nsDocShellLoadState.h. rs=bustage-fix
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 7•5 years ago
|
||
We should pull out those using namespace mozilla;
again when M-C fix bug 1588065.
Target Milestone: --- → Thunderbird 71.0
Assignee | ||
Updated•5 years ago
|
Attachment #9100421 -
Attachment is obsolete: true
Assignee | ||
Updated•5 years ago
|
Attachment #9100427 -
Flags: review?(benc)
Comment 8•5 years ago
|
||
Comment on attachment 9100427 [details] [diff] [review] 1588057.patch Review of attachment 9100427 [details] [diff] [review]: ----------------------------------------------------------------- Looks like a fine workaround to me. I'll be curious to see how Bug 1588065 shakes out. It seems like an oddly obvious oversight!
Attachment #9100427 -
Flags: review?(benc) → review+
Pushed by mozilla@jorgk.com: https://hg.mozilla.org/comm-central/rev/c5c692c1095b remove hacky 'using namespace mozilla' workaround again. r=me
You need to log in
before you can comment on or make changes to this bug.
Description
•