Closed Bug 1588057 Opened 6 months ago Closed 6 months ago

Port bug 1578624: Adjust arguments of LoadURI

Categories

(MailNews Core :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 71.0

People

(Reporter: jorgk-bmo, Assigned: jorgk-bmo)

Details

Attachments

(2 files, 1 obsolete file)

Attached patch 1588057.patch (obsolete) — Splinter Review

Still compiling ...

Assignee: nobody → jorgk
Attached patch m-c-fix.patchSplinter Review

Looks like some M-C stuff is broken, too :-(

Filed bug 1588065 for the M-C issue.

Attached patch 1588057.patchSplinter Review

Here's a hacky workaround for the M-C issue. Just add the missing namespace before including the faulty include file. Compiles so far.

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/d7b26f4d5ea1
Port bug 1578624: Add 'set navigating' argument of nsIDocShell.loadURI() calls. Also hack namespace issue in nsDocShellLoadState.h. rs=bustage-fix

Status: NEW → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED

We should pull out those using namespace mozilla; again when M-C fix bug 1588065.

Target Milestone: --- → Thunderbird 71.0
Attachment #9100421 - Attachment is obsolete: true
Attachment #9100427 - Flags: review?(benc)
Comment on attachment 9100427 [details] [diff] [review]
1588057.patch

Review of attachment 9100427 [details] [diff] [review]:
-----------------------------------------------------------------

Looks like a fine workaround to me.
I'll be curious to see how Bug 1588065 shakes out. It seems like an oddly obvious oversight!
Attachment #9100427 - Flags: review?(benc) → review+
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/c5c692c1095b
remove hacky 'using namespace mozilla' workaround again. r=me
You need to log in before you can comment on or make changes to this bug.