Closed Bug 1588123 Opened 5 years ago Closed 5 years ago

Update libdav1d to head

Categories

(Core :: Audio/Video: Playback, task, P2)

task

Tracking

()

RESOLVED FIXED
mozilla72
Tracking Status
firefox72 --- fixed

People

(Reporter: padenot, Assigned: dminor)

References

Details

Attachments

(1 file, 1 obsolete file)

libdav1d 0.5 has just been released, with lots of optimizations for ARM, ARM64 and x86, and some bug fixes in addition.

Please note:

<unlord> Hi guys, dav1d-0.5.0 was released last night
<unlord> but please be sure to take at least the next commit when uplifting since it contains a symbol alignment fix
<unlord> Yep, just thought I'd warn you: https://code.videolan.org/videolan/dav1d/commit/a6228f47f
Flags: needinfo?(achronop)

Thanks, the merge day is in 10 days (2019-10-21). I think it is better to wait until then. The current import is from 19 of September. Feel free to let me know if you disagree.

Assignee: nobody → achronop
Flags: needinfo?(achronop)
Priority: -- → P3

Nils asked me to handle this update since Alex is busy. I'll prepare the update and plan to land early in Firefox 72.

Assignee: achronop → dminor
Status: NEW → ASSIGNED
Priority: P3 → P2
Pushed by dminor@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c3295fe9b509
Update libdavid to 0.5 + one commit; r=TD-Linux

Backed out changeset c3295fe9b509 (Bug 1588123) for bustages complaining about rules.mk & recurse.mk

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=build-linux&tochange=62e9b2594f1d996055072603c1342937b68dfdcc&fromchange=f4520f5c3cdb693753d5fc04f96111d32da3bdaa&selectedJob=272396843

Backout link: https://hg.mozilla.org/integration/autoland/rev/62e9b2594f1d996055072603c1342937b68dfdcc

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=272396843&repo=autoland&lineNumber=40531

[task 2019-10-22T14:57:44.251Z] 14:57:44 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/mfbt/tests'
[task 2019-10-22T14:57:44.459Z] 14:57:44 INFO - make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/toolkit/library/build'
[task 2019-10-22T14:57:44.463Z] 14:57:44 INFO - /builds/worker/fetches/sccache/sccache /builds/worker/fetches/clang/bin/clang++ --target=aarch64-linux-gnu -Qunused-arguments -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -Qunused-arguments -Wall -Wbitfield-enum-conversion -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtype-limits -Wunreachable-code -Wunreachable-code-return -Wwrite-strings -Wno-invalid-offsetof -Wclass-varargs -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wc++1z-compat -Wc++2a-compat -Wcomma -Wimplicit-fallthrough -Werror=non-literal-null-conversion -Wstring-conversion -Wtautological-overlap-compare -Wtautological-unsigned-enum-zero-compare -Wtautological-unsigned-zero-compare -Wno-error=tautological-type-limit-compare -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=backend-plugin -Wno-error=return-std-move -Wno-error=atomic-alignment -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments -Wno-unknown-warning-option -Wno-return-type-c-linkage -fno-sized-deallocation -fno-aligned-new -fcrash-diagnostics-dir=/builds/worker/artifacts -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -Xclang -load -Xclang /builds/worker/workspace/build/src/obj-firefox/build/clang-plugin/libclang-plugin.so -Xclang -add-plugin -Xclang moz-check -O2 -fno-omit-frame-pointer -funwind-tables -Werror -fPIC -shared -Wl,-z,defs -Wl,--gc-sections -Wl,-h,libxul.so -o libxul.so /builds/worker/workspace/build/src/obj-firefox/toolkit/library/build/libxul_so.list -lpthread -fstack-protector-strong -Wl,-z,noexecstack -Wl,-z,text -Wl,-z,relro -Wl,-z,nocopyreloc -Wl,-Bsymbolic-functions -Wl,--build-id=sha1 -Wl,-rpath-link,/builds/worker/workspace/build/src/obj-firefox/dist/bin -Wl,-rpath-link,/usr/local/lib ../../../security/nss/lib/crmf/crmf_crmf/libcrmf.a ../../../js/src/build/libjs_static.a /builds/worker/workspace/build/src/obj-firefox/aarch64-unknown-linux-gnu/release/libgkrust.a ../../../config/external/nspr/pr/libnspr4.so ../../../config/external/nspr/libc/libplc4.so ../../../config/external/nspr/ds/libplds4.so ../../../config/external/lgpllibs/liblgpllibs.so ../../../security/nss/lib/nss/nss_nss3/libnss3.so ../../../security/nss/lib/util/util_nssutil3/libnssutil3.so ../../../security/nss/lib/smime/smime_smime3/libsmime3.so ../../../config/external/sqlite/libmozsqlite3.so ../../../security/nss/lib/ssl/ssl_ssl3/libssl3.so ../../../widget/gtk/mozgtk/stub/libmozgtk_stub.so ../../../widget/gtk/mozwayland/libmozwayland.so -Wl,--version-script,symverscript -ldl -lrt -lm -lX11 -lX11-xcb -lxcb -lXcomposite -lXcursor -lXdamage -lXext -lXfixes -lXi -lXrender -lpthread -ldl -lc -L/usr/lib/aarch64-linux-gnu -lfreetype -lfontconfig -ldbus-glib-1 -ldbus-1 -lgobject-2.0 -lglib-2.0 -lpangocairo-1.0 -lpango-1.0 -latk-1.0 -lcairo-gobject -lcairo -lgdk_pixbuf-2.0 -lgio-2.0 -lxcb-shm -lpangoft2-1.0 -lXt -lgthread-2.0
[task 2019-10-22T14:57:44.463Z] 14:57:44 INFO - /builds/worker/fetches/binutils/bin/ld: ../../../media/libdav1d/16bd_ipred_tmpl.o: in function dav1d_intra_pred_dsp_init_16bpc': [task 2019-10-22T14:57:44.463Z] 14:57:44 INFO - /builds/worker/workspace/build/src/obj-firefox/media/libdav1d/16bd_ipred_tmpl.c:762: undefined reference todav1d_intra_pred_dsp_init_arm_16bpc'
[task 2019-10-22T14:57:44.463Z] 14:57:44 INFO - /builds/worker/fetches/binutils/bin/ld: ../../../media/libdav1d/8bd_ipred_tmpl.o: in function dav1d_intra_pred_dsp_init_8bpc': [task 2019-10-22T14:57:44.463Z] 14:57:44 INFO - /builds/worker/workspace/build/src/obj-firefox/media/libdav1d/8bd_ipred_tmpl.c:762: undefined reference todav1d_intra_pred_dsp_init_arm_8bpc'
[task 2019-10-22T14:57:44.463Z] 14:57:44 INFO - /builds/worker/fetches/binutils/bin/ld: libxul.so: hidden symbol dav1d_intra_pred_dsp_init_arm_16bpc' isn't defined [task 2019-10-22T14:57:44.463Z] 14:57:44 INFO - /builds/worker/fetches/binutils/bin/ld: final link failed: bad value [task 2019-10-22T14:57:44.463Z] 14:57:44 INFO - clang-9: error: linker command failed with exit code 1 (use -v to see invocation) [task 2019-10-22T14:57:44.463Z] 14:57:44 ERROR - make[4]: *** [/builds/worker/workspace/build/src/config/rules.mk:661: libxul.so] Error 1 [task 2019-10-22T14:57:44.463Z] 14:57:44 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/toolkit/library/build' [task 2019-10-22T14:57:44.464Z] 14:57:44 ERROR - make[3]: *** [/builds/worker/workspace/build/src/config/recurse.mk:74: toolkit/library/build/target] Error 2 [task 2019-10-22T14:57:44.464Z] 14:57:44 INFO - make[3]: *** Waiting for unfinished jobs.... [task 2019-10-22T14:57:45.247Z] 14:57:45 INFO - make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/mfbt/tests' [task 2019-10-22T14:57:45.247Z] 14:57:45 INFO - /builds/worker/workspace/build/src/obj-firefox/_virtualenvs/init/bin/python -m mozbuild.action.dumpsymbols /builds/worker/workspace/build/src/obj-firefox/mfbt/tests/TestSplayTree /builds/worker/workspace/build/src/obj-firefox/mfbt/tests/TestSplayTree_syms.track [task 2019-10-22T14:57:45.247Z] 14:57:45 INFO - Running: /builds/worker/workspace/build/src/obj-firefox/_virtualenvs/init/bin/python /builds/worker/workspace/build/src/toolkit/crashreporter/tools/symbolstore.py -c --vcs-info --install-manifest=/builds/worker/workspace/build/src/obj-firefox/_build_manifests/install/dist_include,/builds/worker/workspace/build/src/obj-firefox/dist/include -s /builds/worker/workspace/build/src /builds/worker/workspace/build/src/obj-firefox/dist/host/bin/dump_syms /builds/worker/workspace/build/src/obj-firefox/dist/crashreporter-symbols /builds/worker/workspace/build/src/obj-firefox/mfbt/tests/TestSplayTree [task 2019-10-22T14:57:45.247Z] 14:57:45 INFO - Beginning work for file: /builds/worker/workspace/build/src/obj-firefox/mfbt/tests/TestSplayTree [task 2019-10-22T14:57:45.247Z] 14:57:45 INFO - Processing file: /builds/worker/workspace/build/src/obj-firefox/mfbt/tests/TestSplayTree [task 2019-10-22T14:57:45.247Z] 14:57:45 INFO - /builds/worker/workspace/build/src/obj-firefox/dist/host/bin/dump_syms /builds/worker/workspace/build/src/obj-firefox/mfbt/tests/TestSplayTree [task 2019-10-22T14:57:45.247Z] 14:57:45 INFO - Finished processing /builds/worker/workspace/build/src/obj-firefox/mfbt/tests/TestSplayTree in 0.00s [task 2019-10-22T14:57:45.248Z] 14:57:45 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/mfbt/tests' [task 2019-10-22T14:57:45.632Z] 14:57:45 INFO - make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/toolkit/library/gtest' [task 2019-10-22T14:57:45.633Z] 14:57:45 INFO - /builds/worker/fetches/sccache/sccache /builds/worker/fetches/clang/bin/clang++ --target=aarch64-linux-gnu -Qunused-arguments -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -Qunused-arguments -Wall -Wbitfield-enum-conversion -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtype-limits -Wunreachable-code -Wunreachable-code-return -Wwrite-strings -Wno-invalid-offsetof -Wclass-varargs -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wc++1z-compat -Wc++2a-compat -Wcomma -Wimplicit-fallthrough -Werror=non-literal-null-conversion -Wstring-conversion -Wtautological-overlap-compare -Wtautological-unsigned-enum-zero-compare -Wtautological-unsigned-zero-compare -Wno-error=tautological-type-limit-compare -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=backend-plugin -Wno-error=return-std-move -Wno-error=atomic-alignment -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments -Wno-unknown-warning-option -Wno-return-type-c-linkage -fno-sized-deallocation -fno-aligned-new -fcrash-diagnostics-dir=/builds/worker/artifacts -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -Xclang -load -Xclang /builds/worker/workspace/build/src/obj-firefox/build/clang-plugin/libclang-plugin.so -Xclang -add-plugin -Xclang moz-check -O2 -fno-omit-frame-pointer -funwind-tables -Werror -fPIC -shared -Wl,-z,defs -Wl,--gc-sections -Wl,-h,libxul.so -o libxul.so /builds/worker/workspace/build/src/obj-firefox/toolkit/library/gtest/libxul_so.list -lpthread -fstack-protector-strong -Wl,-z,noexecstack -Wl,-z,text -Wl,-z,relro -Wl,-z,nocopyreloc -Wl,-Bsymbolic-functions -Wl,--build-id=sha1 -Wl,-rpath-link,/builds/worker/workspace/build/src/obj-firefox/dist/bin -Wl,-rpath-link,/usr/local/lib ../../../security/nss/lib/crmf/crmf_crmf/libcrmf.a ../../../js/src/build/libjs_static.a /builds/worker/workspace/build/src/obj-firefox/aarch64-unknown-linux-gnu/release/libgkrust_gtest.a ../../../config/external/nspr/pr/libnspr4.so ../../../config/external/nspr/libc/libplc4.so ../../../config/external/nspr/ds/libplds4.so ../../../config/external/lgpllibs/liblgpllibs.so ../../../security/nss/lib/nss/nss_nss3/libnss3.so ../../../security/nss/lib/util/util_nssutil3/libnssutil3.so ../../../security/nss/lib/smime/smime_smime3/libsmime3.so ../../../config/external/sqlite/libmozsqlite3.so ../../../security/nss/lib/ssl/ssl_ssl3/libssl3.so ../../../widget/gtk/mozgtk/stub/libmozgtk_stub.so ../../../widget/gtk/mozwayland/libmozwayland.so -Wl,--version-script,symverscript -ldl -lrt -lm -lX11 -lX11-xcb -lxcb -lXcomposite -lXcursor -lXdamage -lXext -lXfixes -lXi -lXrender -lpthread -ldl -lc -L/usr/lib/aarch64-linux-gnu -lfreetype -lfontconfig -ldbus-glib-1 -ldbus-1 -lgobject-2.0 -lglib-2.0 -lpangocairo-1.0 -lpango-1.0 -latk-1.0 -lcairo-gobject -lcairo -lgdk_pixbuf-2.0 -lgio-2.0 -lxcb-shm -lpangoft2-1.0 -lXt -lgthread-2.0 [task 2019-10-22T14:57:45.633Z] 14:57:45 INFO - /builds/worker/fetches/binutils/bin/ld: ../../../media/libdav1d/16bd_ipred_tmpl.o: in functiondav1d_intra_pred_dsp_init_16bpc':
[task 2019-10-22T14:57:45.634Z] 14:57:45 INFO - /builds/worker/workspace/build/src/obj-firefox/media/libdav1d/16bd_ipred_tmpl.c:762: undefined reference to dav1d_intra_pred_dsp_init_arm_16bpc' [task 2019-10-22T14:57:45.634Z] 14:57:45 INFO - /builds/worker/fetches/binutils/bin/ld: ../../../media/libdav1d/8bd_ipred_tmpl.o: in functiondav1d_intra_pred_dsp_init_8bpc':
[task 2019-10-22T14:57:45.634Z] 14:57:45 INFO - /builds/worker/workspace/build/src/obj-firefox/media/libdav1d/8bd_ipred_tmpl.c:762: undefined reference to dav1d_intra_pred_dsp_init_arm_8bpc' [task 2019-10-22T14:57:45.634Z] 14:57:45 INFO - /builds/worker/fetches/binutils/bin/ld: libxul.so: hidden symboldav1d_intra_pred_dsp_init_arm_16bpc' isn't defined
[task 2019-10-22T14:57:45.634Z] 14:57:45 INFO - /builds/worker/fetches/binutils/bin/ld: final link failed: bad value
[task 2019-10-22T14:57:45.634Z] 14:57:45 INFO - clang-9: error: linker command failed with exit code 1 (use -v to see invocation)
[task 2019-10-22T14:57:45.634Z] 14:57:45 ERROR - make[4]: *** [/builds/worker/workspace/build/src/config/rules.mk:661: libxul.so] Error 1
[task 2019-10-22T14:57:45.634Z] 14:57:45 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/toolkit/library/gtest'
[task 2019-10-22T14:57:45.635Z] 14:57:45 ERROR - make[3]: *** [/builds/worker/workspace/build/src/config/recurse.mk:74: toolkit/library/gtest/target] Error 2
[task 2019-10-22T14:57:46.212Z] 14:57:46 INFO - make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/mfbt/tests'
[task 2019-10-22T14:57:46.213Z] 14:57:46 INFO - /builds/worker/workspace/build/src/obj-firefox/_virtualenvs/init/bin/python -m mozbuild.action.dumpsymbols /builds/worker/workspace/build/src/obj-firefox/mfbt/tests/TestSPSCQueue /builds/worker/workspace/build/src/obj-firefox/mfbt/tests/TestSPSCQueue_syms.track
[task 2019-10-22T14:57:46.213Z] 14:57:46 INFO - Running: /builds/worker/workspace/build/src/obj-firefox/_virtualenvs/init/bin/python /builds/worker/workspace/build/src/toolkit/crashreporter/tools/symbolstore.py -c --vcs-info --install-manifest=/builds/worker/workspace/build/src/obj-firefox/_build_manifests/install/dist_include,/builds/worker/workspace/build/src/obj-firefox/dist/include -s /builds/worker/workspace/build/src /builds/worker/workspace/build/src/obj-firefox/dist/host/bin/dump_syms /builds/worker/workspace/build/src/obj-firefox/dist/crashreporter-symbols /builds/worker/workspace/build/src/obj-firefox/mfbt/tests/TestSPSCQueue
[task 2019-10-22T14:57:46.213Z] 14:57:46 INFO - Beginning work for file: /builds/worker/workspace/build/src/obj-firefox/mfbt/tests/TestSPSCQueue
[task 2019-10-22T14:57:46.213Z] 14:57:46 INFO - Processing file: /builds/worker/workspace/build/src/obj-firefox/mfbt/tests/TestSPSCQueue
[task 2019-10-22T14:57:46.213Z] 14:57:46 INFO - /builds/worker/workspace/build/src/obj-firefox/dist/host/bin/dump_syms /builds/worker/workspace/build/src/obj-firefox/mfbt/tests/TestSPSCQueue
[task 2019-10-22T14:57:46.213Z] 14:57:46 INFO - Finished processing /builds/worker/workspace/build/src/obj-firefox/mfbt/tests/TestSPSCQueue in 0.00s
[task 2019-10-22T14:57:46.213Z] 14:57:46 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/mfbt/tests'
....
[task 2019-10-22T14:57:58.654Z] 14:57:58 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/mfbt/tests'
[task 2019-10-22T14:57:59.618Z] 14:57:59 INFO - make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/mfbt/tests'
[task 2019-10-22T14:57:59.618Z] 14:57:59 INFO - /builds/worker/workspace/build/src/obj-firefox/_virtualenvs/init/bin/python -m mozbuild.action.dumpsymbols /builds/worker/workspace/build/src/obj-firefox/mfbt/tests/TestPoisonArea /builds/worker/workspace/build/src/obj-firefox/mfbt/tests/TestPoisonArea_syms.track
[task 2019-10-22T14:57:59.618Z] 14:57:59 INFO - Running: /builds/worker/workspace/build/src/obj-firefox/_virtualenvs/init/bin/python /builds/worker/workspace/build/src/toolkit/crashreporter/tools/symbolstore.py -c --vcs-info --install-manifest=/builds/worker/workspace/build/src/obj-firefox/_build_manifests/install/dist_include,/builds/worker/workspace/build/src/obj-firefox/dist/include -s /builds/worker/workspace/build/src /builds/worker/workspace/build/src/obj-firefox/dist/host/bin/dump_syms /builds/worker/workspace/build/src/obj-firefox/dist/crashreporter-symbols /builds/worker/workspace/build/src/obj-firefox/mfbt/tests/TestPoisonArea
[task 2019-10-22T14:57:59.618Z] 14:57:59 INFO - Beginning work for file: /builds/worker/workspace/build/src/obj-firefox/mfbt/tests/TestPoisonArea
[task 2019-10-22T14:57:59.618Z] 14:57:59 INFO - Processing file: /builds/worker/workspace/build/src/obj-firefox/mfbt/tests/TestPoisonArea
[task 2019-10-22T14:57:59.619Z] 14:57:59 INFO - /builds/worker/workspace/build/src/obj-firefox/dist/host/bin/dump_syms /builds/worker/workspace/build/src/obj-firefox/mfbt/tests/TestPoisonArea
[task 2019-10-22T14:57:59.619Z] 14:57:59 INFO - Finished processing /builds/worker/workspace/build/src/obj-firefox/mfbt/tests/TestPoisonArea in 0.00s
[task 2019-10-22T14:57:59.619Z] 14:57:59 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/mfbt/tests'
[task 2019-10-22T14:57:59.619Z] 14:57:59 ERROR - make[2]: *** [/builds/worker/workspace/build/src/config/recurse.mk:34: compile] Error 2
[task 2019-10-22T14:57:59.619Z] 14:57:59 ERROR - make[1]: *** [/builds/worker/workspace/build/src/config/rules.mk:389: default] Error 2
[task 2019-10-22T14:57:59.620Z] 14:57:59 INFO - make: *** [client.mk:125: build] Error 2
[task 2019-10-22T14:57:59.623Z] 14:57:59 INFO - 318 compiler warnings present.
[task 2019-10-22T14:57:59.769Z] 14:57:59 ERROR - Return code: 2
[task 2019-10-22T14:57:59.769Z] 14:57:59 WARNING - setting return code to 2
[task 2019-10-22T14:57:59.769Z] 14:57:59 FATAL - 'mach build -v' did not run successfully. Please check log for errors.
[task 2019-10-22T14:57:59.769Z] 14:57:59 FATAL - Running post_fatal callback...
[task 2019-10-22T14:57:59.769Z] 14:57:59 FATAL - Exiting -1
[task 2019-10-22T14:57:59.769Z] 14:57:59 INFO - [mozharness: 2019-10-22 14:57:59.769693Z] Finished build step (failed)

Flags: needinfo?(dminor)

Sorry, missed arm platforms when doing try runs.

Flags: needinfo?(dminor)

Nils has requested that we update to head instead of 0.5 to pick up some SSE2 improvements.

Summary: Update libdavid to 0.5 + one commit → Update libdav1d to head
Attachment #9102934 - Attachment is obsolete: true

This updates libdav1d to commit 5595102721d3c298d7cee64e64878486a3b8bdad.

Pushed by dminor@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/59062c355993
Update libdav1d to head; r=TD-Linux
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: