Closed Bug 1588124 Opened 5 years ago Closed 5 years ago

AllocKinds.h suggests that atoms can be moved by compacting GC

Categories

(Core :: JavaScript: GC, task, P2)

Product:
Core
Component:
JavaScript: GC
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla71
Tracking Flags:
Tracking Status
firefox71 --- fixed

People

(Reporter: jonco, Assigned: jonco)

Details

Attachments

(1 file)

Bug 1588124 - Mark atom kinds as not compactable in AllocKinds.h for consistency, since we don't compact the atoms zone r?sfink
47 bytes, text/x-phabricator-request
Details | Review

The 'compact' field for both types of atoms in FOR_EACH_NONOBJECT_NONNURSERY_ALLOCKIND is true, despite the fact that we don't move atoms. This is confusing. It should be false here for consistency.

Assignee: nobody → jcoppeard
Priority: -- → P2
Pushed by jcoppeard@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ccc497d7fbe9 Mark atom kinds as not compactable in AllocKinds.h for consistency, since we don't compact the atoms zone r=sfink

https://hg.mozilla.org/mozilla-central/rev/ccc497d7fbe9

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox71: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: