1588236 - [wpt-sync] Sync PR 19651 - [css-text] Consider breaking opportunities of inline siblings

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, task, P4)

Description

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 19651 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/19651
Details from upstream follow.

Javier Fernandez <[e-mail]> wrote:

[css-text] Consider breaking opportunities of inline siblings

First of all, bear in mind that this change affects only to
intrinsic size computation in legacy layout.

During the intrinsic size computation of blocks with inline children,
we are determining the breaking opportunities for each child. When the
word-break: break-word is used, each of this breaking opportunities
should account for the min-content size.

Hence, we can't simply ignore that previous inline siblings had an
opportunity already. This patch proposes to consider that both values,
break-word and break-all, imply that every position is a potential
breakable location, at least regarding the intrinsic size computation.

Bug: 1013644
Change-Id: I04261b323cd029a624724363a566fccc826863af
Reviewed-on: https://chromium-review.googlesource.com/1856959
WPT-Export-Revision: 25018e0d3271dc965758e39b57997bd72569f223

Comment 1

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=a8d6c353910f78a3babc1205f0e5c6928bbe4f30

Comment 2

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

GitHub CI Results

wpt.fyi PR Results Base Results

Ran 6 tests

Firefox

PASS: 6

Chrome

PASS: 6

Safari

PASS: 3
FAIL: 3

Gecko CI Results

Ran 6 tests
PASS : 6

Comment 3

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Attachment: Bug 1588236 [wpt PR 19651] - [css-text] Consider breaking opportunities of inline siblings, a=testonly

Automatic update from web-platform-tests
[css-text] Consider breaking opportunities of inline siblings

First of all, bear in mind that this change affects only to
intrinsic size computation in legacy layout.

During the intrinsic size computation of blocks with inline children,
we are determining the breaking opportunities for each child. When the
word-break: break-word is used, each of this breaking opportunities
should account for the min-content size.

We only consider breakable locations for start and end if they are
br elements or spaces, under auto-wrap, to compute the intrinsic size
of a box. This is fine, since we are already using a break iterator
to determine the min-size of each word. However, we were incorrectly
summing the first_line_min_width for each inline sibling, even when
they were part of the same text line.

This change tries to avoid that problem by assuming that there is
always a breaking opportunity after every character, since the
spec now states that break-word should behave as normal and
overflow-wrap: anywhere.

Bug: 1013644
Change-Id: I04261b323cd029a624724363a566fccc826863af
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856959
Reviewed-by: Koji Ishii <[e-mail]>
Commit-Queue: Javier Fernandez <[e-mail]>
Cr-Commit-Position: refs/heads/master@{#710359}

--

wpt-commits: 87d9d891e4f0c2276cc4ad4bbd7e101a7c9b05d9
wpt-pr: 19651

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0907a4ea294c
[wpt PR 19651] - [css-text] Consider breaking opportunities of inline siblings, a=testonly

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/0907a4ea294c