1588283 - Incorrect build failure reported

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, defect, P1)

Description

[Sylvestre Ledru [:Sylvestre]]

Working on my regular reformat of the tree:
https://phabricator.services.mozilla.com/D49056#change-uV2apxZFhyBu
I received a build failure notification (email)

Code Review bot found 1 build errors on D49056

Message: use of undeclared identifier 'MOZ_APP_VERSION'
Location: toolkit/mozapps/update/updater/updater.cpp:2522

Full log:
https://taskcluster-artifacts.net/fdccGXWmQaK0fEXOMH5YFw/0/public/logs/live_backing.log

Seems to be caused by:
[task 2019-10-12T07:31:32.901Z] [WARNING] Argument not recognized by Coverity compiler: '-DMOZ_APP_VERSION="71.0a1"'

Side note: 1 build error(s)

Comment 1

[Sylvestre Ledru [:Sylvestre]]

Andi, Any idea what is going on here?

Comment 2

[Andi [:andi]]

I've opened a ticket to Coverity for this issue. Definitely it's an issue with cov-translate.

Comment 3

[Andi [:andi]]

The emails are going back and forward with Synopsys Support, we've provided them with everything that they asked but unfortunately we don't have a resolution yet.

Comment 4

[Andi [:andi]]

Synopsys confirmed this is a bug on their side and they assigned a ticket for this, #CMPCPP-952m. I'm pursuing a workaround for this since we don't know how long it will take to have this fixed.

Comment 5

[Andi [:andi]]

We have this workaround for this issue, but this by far is not a fix, Coverity should be fully compatible with the formatting of compile_commands.json.

Comment 6

[Andi [:andi]]

Attachment: Bug 1588283 - Incorrect build failure reported by coverity when using inline definitions. r=bastien

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1ee997d2152a
Incorrect build failure reported by coverity when using inline definitions. r=bastien

Comment 8

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/1ee997d2152a

Comment 9

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1ee997d2152a