Closed
Bug 1588302
Opened 6 years ago
Closed 6 years ago
Refactor heap state a little
Categories
(Core :: JavaScript: GC, task, P3)
Core
JavaScript: GC
Tracking
()
RESOLVED
FIXED
mozilla71
| Tracking | Status | |
|---|---|---|
| firefox71 | --- | fixed |
People
(Reporter: jonco, Assigned: jonco)
Details
Attachments
(3 files)
The heap state should really live GCRuntime rather than JSRuntime, and its accessor functions should live in a GC header rather than jspubtd.h.
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → jcoppeard
Priority: -- → P3
|
|
Assignee | |
Comment 1•6 years ago
|
||
jspubtd.h is for type definitions so this moves the heap state functions to somewhere more suitable.
Depends on D49116
|
|
Assignee | |
Comment 2•6 years ago
|
||
The heap state is GC data; it should live in GCRuntime.
Depends on D49117
|
|
Assignee | |
Comment 3•6 years ago
|
||
Depends on D49118
Pushed by jcoppeard@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d1fb75a00d99
Move heap state accessors to public/HeapAPI.h r=sfink
https://hg.mozilla.org/integration/autoland/rev/41320766c363
Move heap state to GCRuntime r=sfink
https://hg.mozilla.org/integration/autoland/rev/98a43588ff8a
Make AutoHeapSession use a GCRuntime pointer r=sfink
|
||
Comment 5•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/d1fb75a00d99
https://hg.mozilla.org/mozilla-central/rev/41320766c363
https://hg.mozilla.org/mozilla-central/rev/98a43588ff8a
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox71:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
You need to log in
before you can comment on or make changes to this bug.
Description
•