Closed Bug 1588311 Opened 6 years ago Closed 6 years ago

Click event not fired when changing input placeholder on focus

Categories

(Core :: DOM: Events, defect, P3)

Product:
Core
Component:
DOM: Events
Version:
69 Branch
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla72
Tracking Flags:
Tracking Status
firefox72 --- fixed

People

(Reporter: jerzy, Assigned: smaug)

References

Details

Attachments

(2 files)

testcase
308 bytes, text/html
Details
Bug 1588311 - Update mousedown targets when native anonymous content is recreated, r=masayuki
47 bytes, text/x-phabricator-request
Details | Review

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:69.0) Gecko/20100101 Firefox/69.0

Steps to reproduce:

https://jsfiddle.net/aq3sn7rw/

Attach event listener for focus event on the text input that has a placeholder set. In the handler, change the placeholder text.

When you click on the input the click event is not fired. When you click the second time it gets raised.

Actual results:

Clicking on the input doesn't fire click event.

Expected results:

Click event gets fired.

Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: needinfo?(jdai)
Priority: -- → P3

Hmm, mousedown happens on NAC, which is then disconnected from dom or something?
Or, rather, do we consider <input> as interactive content there so we stop looking for the common ancestor too early

Flags: needinfo?(bugs)

Hmm, we do recreate frames, so placeholder NAC is replaced.

Oh, and I'm fixing this :)

Assignee: nobody → bugs
Flags: needinfo?(bugs)
Attached file testcase —

jsfiddle was down

Pushed by opettay@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e81731a64af6 Update mousedown targets when native anonymous content is recreated, r=masayuki
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/20135 for changes under testing/web-platform/tests
Upstream PR was closed without merging

Backed out changeset e81731a64af6 (bug 1588311) for wpt failures at uievents/click/click_events_on_input.html

Backout: https://hg.mozilla.org/integration/autoland/rev/8236fffe6f10e3b69e5cc97053df691645559c05

Failure push: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=e81731a64af67d360d42563e2b19e251581b3dc3

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=274913104&repo=autoland&lineNumber=5223

task 2019-11-06T22:13:19.828Z] 22:13:19 INFO - TEST-START | /uievents/click/click_events_on_input.html
[task 2019-11-06T22:13:19.829Z] 22:13:19 INFO - Closing window 18
[task 2019-11-06T22:13:20.027Z] 22:13:20 INFO - {'actions': [{u'type': u'none', u'id': u'0', u'actions': [{u'duration': 16, u'type': u'pause'}, {u'duration': 16, u'type': u'pause'}, {u'duration': 16, u'type': u'pause'}]}, {u'type': u'pointer', u'actions': [{u'y': 10, u'x': 83, u'frame': {u'frame': u'window'}, u'type': u'pointerMove', u'origin': {'element-6066-11e4-a52e-4f735466cecf': u'472f1d7e-4831-42cf-8438-7fe0769d7ffd', 'chromeelement-9fc5-4b51-a3c8-01716eedeb04': u'472f1d7e-4831-42cf-8438-7fe0769d7ffd'}}, {u'button': 0, u'type': u'pointerDown'}, {u'button': 0, u'type': u'pointerUp'}], u'parameters': {u'pointerType': u'mouse'}, u'id': u'1'}]}
[task 2019-11-06T22:14:00.015Z] 22:14:00 INFO -
[task 2019-11-06T22:14:00.015Z] 22:14:00 INFO - TEST-UNEXPECTED-NOTRUN | /uievents/click/click_events_on_input.html | Test click and auxclick on input element - expected PASS
[task 2019-11-06T22:14:00.458Z] 22:14:00 INFO - TEST-UNEXPECTED-TIMEOUT | /uievents/click/click_events_on_input.html | expected OK
[task 2019-11-06T22:14:00.458Z] 22:14:00 INFO - TEST-INFO took 40630ms
[task 2019-11-06T22:14:01.219Z] 22:14:01 INFO - Closing logging queue
[task 2019-11-06T22:14:01.219Z] 22:14:01 INFO - queue closed
[task 2019-11-06T22:14:01.235Z] 22:14:01 INFO - Setting up ssl
[task 2019-11-06T22:14:01.250Z] 22:14:01 INFO - certutil |
[task 2019-11-06T22:14:01.270Z] 22:14:01 INFO - certutil |
[task 2019-11-06T22:14:01.286Z] 22:14:01 INFO - certutil |
[task 2019-11-06T22:14:01.286Z] 22:14:01 INFO - Certificate Nickname Trust Attributes
[task 2019-11-06T22:14:01.286Z] 22:14:01 INFO - SSL,S/MIME,JAR/XPI
[task 2019-11-06T22:14:01.286Z] 22:14:01 INFO -
[task 2019-11-06T22:14:01.286Z] 22:14:01 INFO - web-platform-tests CT,,
[task 2019-11-06T22:14:01.286Z] 22:14:01 INFO -
[task 2019-11-06T22:14:04.057Z] 22:14:04 INFO - adb Granting important runtime permissions to org.mozilla.geckoview.test
[task 2019-11-06T22:14:05.319Z] 22:14:05 INFO - adb launch_application: am start -W -n org.mozilla.geckoview.test/org.mozilla.geckoview.test.TestRunnerActivity -a android.intent.action.MAIN --es env9 MOZ_DISABLE_NONLOCAL_CONNECTIONS=1 --es env8 R_LOG_DESTINATION=stderr --es args "-no-remote -profile /sdcard/tests/profile --marionette about:blank" --es env3 MOZ_HIDE_RESULTS_TABLE=1 --es env2 R_LOG_VERBOSE=1 --es env1 MOZ_WEBRENDER=0 --es env0 MOZ_CRASHREPORTER=1 --es env7 MOZ_CRASHREPORTER_SHUTDOWN=1 --es env6 MOZ_IN_AUTOMATION=1 --es env5 MOZ_LOG=signaling:3,mtransport:4,DataChannel:4,jsep:4 --es env4 STYLO_THREADS=4 --ez use_multiprocess True --es env12 R_LOG_LEVEL=6 --es env11 MOZ_PROCESS_LOG=/tmp/tmp7c5ZoCpidlog --es env10 MOZ_CRASHREPORTER_NO_REPORT=1
[task 2019-11-06T22:14:06.724Z] 22:14:06 INFO - Starting runner

Flags: needinfo?(bugs)

whaat, it was working before... oh, Android.
I may disable it there.

Flags: needinfo?(bugs)
Flags: needinfo?(jdai)
Pushed by opettay@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/cea0bc072414 Update mousedown targets when native anonymous content is recreated, r=masayuki

https://hg.mozilla.org/mozilla-central/rev/cea0bc072414

Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox72: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
Upstream PR merged by moz-wptsync-bot
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: