Closed Bug 1588501 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 19672 - Rewrite wpt/svg/animations/slider-switch.html to use 'begin' as trigger

Categories

(Core :: SVG, task, P4)

Product:
Core
Component:
SVG
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla72
Tracking Flags:
Tracking Status
firefox72 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 19672 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/19672
Details from upstream follow.

Fredrik Söderquist <fs@opera.com> wrote:

Rewrite wpt/svg/animations/slider-switch.html to use 'begin' as trigger

The interval timer could end up racing with the animation update timer,
meaning that the new animation values had not yet been applied when
the |retries| counter reached zero and the assertions were made.
Refactor the test to trigger the next "action" (new pair of clicks or
checking the result) when one of the timed elements listening on the
"b.click" event has begun. Also change |retries| into counting how many
clicks are remaining (rather than how many interval timer firings).

Bug: 1013736
Change-Id: I374cb9c499ca18a791f76dabcb1db8bcd6f38461
Reviewed-on: https://chromium-review.googlesource.com/1859955
WPT-Export-Revision: 56b1efd37fe1536e1bf8eb67527318af5a0efd71

Component: web-platform-tests → SVG
Product: Testing → Core
## GitHub CI Results
wpt.fyi [PR Results](https://wpt.fyi/results/?sha=51266dd2f75626c1cc76c09db8834df5faf3aa32&label=pr_head) [Base Results](https://wpt.fyi/results/?sha=51266dd2f75626c1cc76c09db8834df5faf3aa32&label=pr_base)

Ran 1 tests and 1 subtests

### Firefox
  OK  : 1
  PASS: 1

### Chrome
  TIMEOUT: 2

### Safari
  TIMEOUT: 2
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3fd8b3cbde10
[wpt PR 19672] - Rewrite wpt/svg/animations/slider-switch.html to use 'begin' as trigger, a=testonly

https://hg.mozilla.org/mozilla-central/rev/3fd8b3cbde10

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox72: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
You need to log in before you can comment on or make changes to this bug.