Open Bug 1588503 Opened 9 months ago Updated 8 months ago

1.81 - 1.92% Base Content JS (linux64, macosx1014-64-shippable, windows10-64) regression on push 25ba54160c0aee63142e87bf06e67b92c89f566a (Wed October 9 2019)

Categories

(Toolkit :: Autocomplete, defect, P2)

defect

Tracking

()

People

(Reporter: Bebe, Unassigned, NeedInfo)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: perf, perf-alert, regression)

We have detected an awsy regression from push:

https://hg.mozilla.org/integration/autoland/pushloghtml?changeset=25ba54160c0aee63142e87bf06e67b92c89f566a

As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

2% Base Content JS macosx1014-64-shippable opt 4,055,838.67 -> 4,133,773.33
2% Base Content JS windows10-64 opt 4,118,246.67 -> 4,196,488.00
2% Base Content JS windows10-64-qr opt 4,118,140.00 -> 4,196,434.67
2% Base Content JS windows10-64-shippable opt 4,118,273.33 -> 4,196,434.67
2% Base Content JS windows10-64-shippable-qr opt 4,118,166.67 -> 4,196,461.33
2% Base Content JS windows10-64-shippable-qr opt 4,119,568.67 -> 4,196,485.33
2% Base Content JS linux64 opt 4,054,836.00 -> 4,128,557.33
2% Base Content JS linux64-qr opt 4,054,942.67 -> 4,128,808.00
2% Base Content JS linux64-shippable opt 4,055,232.00 -> 4,128,656.00
2% Base Content JS linux64-shippable-qr opt 4,055,285.33 -> 4,128,781.33

You can find links to graphs and comparison views for each of the above tests at: https://treeherder.mozilla.org/perf.html#/alerts?id=23452

On the page above you can see an alert for each affected platform as well as a link to a graph showing the history of scores for this test. There is also a link to a treeherder page showing the jobs in a pushlog format.

To learn more about the regressing test(s), please see: https://wiki.mozilla.org/AWSY/Tests

Blocks: 1578356
Component: Performance → Autocomplete
Flags: needinfo?(enndeakin)
Product: Testing → Toolkit
Regressed by: 1573836
Version: Version 3 → unspecified
Priority: -- → P2

This performance regression is caused because the AutoCompleteChild.jsm module is now being loaded at startup due to the actor needing a pageshow event listener to initialize autocomplete for a page, and we don't filter out the initial about:blank. The older framescript version presumably didn't apply to blank pages. The performance test here just starts up with a blank page. There is a discussion of why this was deemed acceptable at https://bugzilla.mozilla.org/show_bug.cgi?id=1584032#c3

Perhaps kmag can clarify if this is an issue we can just ignore or should find a solution for.

Flags: needinfo?(enndeakin) → needinfo?(kmaglione+bmo)
Blocks: 1592626
No longer blocks: 1592626
You need to log in before you can comment on or make changes to this bug.