Closed Bug 1588645 Opened 5 years ago Closed 4 years ago

Intermittent toolkit/components/extensions/test/xpcshell/test_ext_same_site_cookies.js | test_webRequest_same_site_cookie_access - [test_webRequest_same_site_cookie_access : 265] A promise chain failed to handle a rejection: Connection is not open

Categories

(WebExtensions :: General, defect, P5)

defect

Tracking

(firefox71 fixed, firefox72 fixed)

RESOLVED FIXED
mozilla72
Tracking Status
firefox71 --- fixed
firefox72 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: ewright)

References

(Regression)

Details

(Keywords: intermittent-failure, regression, Whiteboard: [retriggered])

Attachments

(1 file, 1 obsolete file)

Filed by: csabou [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=271210450&repo=autoland
Full log: https://queue.taskcluster.net/v1/task/ZgwjG3QdRn2_B7HfLSTGhw/runs/0/artifacts/public/logs/live_backing.log


[task 2019-10-14T22:32:21.216Z] 22:32:21 INFO - TEST-START | xpcshell-remote.ini:toolkit/components/extensions/test/xpcshell/test_ext_same_site_cookies.js
[task 2019-10-14T22:32:23.046Z] 22:32:23 WARNING - TEST-UNEXPECTED-FAIL | xpcshell-remote.ini:toolkit/components/extensions/test/xpcshell/test_ext_same_site_cookies.js | xpcshell return code: 0
[task 2019-10-14T22:32:23.046Z] 22:32:23 INFO - TEST-INFO took 1830ms
[task 2019-10-14T22:32:23.047Z] 22:32:23 INFO - >>>>>>>
[task 2019-10-14T22:32:23.047Z] 22:32:23 INFO - PID 11776 | [11776, Main Thread] WARNING: 'result.isErr()', file z:/build/build/src/startupcache/StartupCache.cpp, line 173
[task 2019-10-14T22:32:23.048Z] 22:32:23 INFO - PID 11776 | [11776, Main Thread] WARNING: Failed to get directory to cache.: file z:/build/build/src/security/sandbox/win/src/sandboxbroker/sandboxBroker.cpp, line 83
[task 2019-10-14T22:32:23.048Z] 22:32:23 INFO - PID 11776 | [11776, Main Thread] WARNING: Failed to get directory to cache.: file z:/build/build/src/security/sandbox/win/src/sandboxbroker/sandboxBroker.cpp, line 83
[task 2019-10-14T22:32:23.048Z] 22:32:23 INFO - PID 11776 | [11776, Main Thread] WARNING: Failed to get directory to cache.: file z:/build/build/src/security/sandbox/win/src/sandboxbroker/sandboxBroker.cpp, line 83
[task 2019-10-14T22:32:23.049Z] 22:32:23 INFO - PID 11776 | [11776, Main Thread] WARNING: Failed to get directory to cache.: file z:/build/build/src/security/sandbox/win/src/sandboxbroker/sandboxBroker.cpp, line 83
[task 2019-10-14T22:32:23.049Z] 22:32:23 INFO - PID 11776 | [11776, Main Thread] WARNING: Failed to get directory to cache.: file z:/build/build/src/security/sandbox/win/src/sandboxbroker/sandboxBroker.cpp, line 83
[task 2019-10-14T22:32:23.049Z] 22:32:23 INFO - PID 11776 | [11776, Main Thread] WARNING: 'result.isErr()', file z:/build/build/src/startupcache/StartupCache.cpp, line 173
[task 2019-10-14T22:32:23.050Z] 22:32:23 INFO - PID 11776 | [11776, Main Thread] WARNING: 'result.isErr()', file z:/build/build/src/startupcache/StartupCache.cpp, line 173
[task 2019-10-14T22:32:23.050Z] 22:32:23 INFO - PID 11776 | [11776, Main Thread] WARNING: 'result.isErr()', file z:/build/build/src/startupcache/StartupCache.cpp, line 173
[task 2019-10-14T22:32:23.050Z] 22:32:23 INFO - PID 11776 | [11776, Main Thread] WARNING: 'result.isErr()', file z:/build/build/src/startupcache/StartupCache.cpp, line 173
[task 2019-10-14T22:32:23.051Z] 22:32:23 INFO - PID 11776 | [11776, Main Thread] WARNING: 'result.isErr()', file z:/build/build/src/startupcache/StartupCache.cpp, line 173
[task 2019-10-14T22:32:23.051Z] 22:32:23 INFO - PID 11776 | [11776, Main Thread] WARNING: 'result.isErr()', file z:/build/build/src/startupcache/StartupCache.cpp, line 173
[task 2019-10-14T22:32:23.051Z] 22:32:23 INFO - PID 11776 | [11776, Main Thread] WARNING: 'result.isErr()', file z:/build/build/src/startupcache/StartupCache.cpp, line 173
[task 2019-10-14T22:32:23.052Z] 22:32:23 INFO - PID 11776 | [11776, Main Thread] WARNING: 'result.isErr()', file z:/build/build/src/startupcache/StartupCache.cpp, line 173
[task 2019-10-14T22:32:23.052Z] 22:32:23 INFO - PID 11776 | [11776, Main Thread] WARNING: 'result.isErr()', file z:/build/build/src/startupcache/StartupCache.cpp, line 173
[task 2019-10-14T22:32:23.052Z] 22:32:23 INFO - PID 11776 | [11776, Main Thread] WARNING: 'result.isErr()', file z:/build/build/src/startupcache/StartupCache.cpp, line 173
[task 2019-10-14T22:32:23.053Z] 22:32:23 INFO - PID 11776 | [11776, Main Thread] WARNING: 'result.isErr()', file z:/build/build/src/startupcache/StartupCache.cpp, line 173
[task 2019-10-14T22:32:23.053Z] 22:32:23 INFO - PID 11776 | [11776, Main Thread] WARNING: Couldn't get the user appdata directory. Crash events may not be produced.: file z:/build/build/src/toolkit/crashreporter/nsExceptionHandler.cpp, line 2632
[task 2019-10-14T22:32:23.054Z] 22:32:23 INFO - PID 11776 | [11776, Main Thread] WARNING: 'result.isErr()', file z:/build/build/src/startupcache/StartupCache.cpp, line 173
[task 2019-10-14T22:32:23.054Z] 22:32:23 INFO - PID 11776 | [11776, Main Thread] WARNING: 'result.isErr()', file z:/build/build/src/startupcache/StartupCache.cpp, line 173
[task 2019-10-14T22:32:23.054Z] 22:32:23 INFO - PID 11776 | [11776, Main Thread] WARNING: 'result.isErr()', file z:/build/build/src/startupcache/StartupCache.cpp, line 173
[task 2019-10-14T22:32:23.054Z] 22:32:23 INFO - PID 11776 | [11776, Main Thread] WARNING: 'result.isErr()', file z:/build/build/src/startupcache/StartupCache.cpp, line 173
[task 2019-10-14T22:32:23.055Z] 22:32:23 INFO - PID 11776 | [11776, Main Thread] WARNING: 'result.isErr()', file z:/build/build/src/startupcache/StartupCache.cpp, line 173
[task 2019-10-14T22:32:23.055Z] 22:32:23 INFO - PID 11776 | [11776, Main Thread] WARNING: 'result.isErr()', file z:/build/build/src/startupcache/StartupCache.cpp, line 173
[task 2019-10-14T22:32:23.055Z] 22:32:23 INFO - PID 11776 | [11776, Main Thread] WARNING: 'result.isErr()', file z:/build/build/src/startupcache/StartupCache.cpp, line 173
[task 2019-10-14T22:32:23.056Z] 22:32:23 INFO - PID 11776 | [11776, Main Thread] WARNING: 'result.isErr()', file z:/build/build/src/startupcache/StartupCache.cpp, line 173
[task 2019-10-14T22:32:23.056Z] 22:32:23 INFO - PID 11776 | [11776, Main Thread] WARNING: 'result.isErr()', file z:/build/build/src/startupcache/StartupCache.cpp, line 173
[task 2019-10-14T22:32:23.056Z] 22:32:23 INFO - PID 11776 | [11776, Main Thread] WARNING: 'result.isErr()', file z:/build/build/src/startupcache/StartupCache.cpp, line 173
[task 2019-10-14T22:32:23.056Z] 22:32:23 INFO - PID 11776 | [11776, Main Thread] WARNING: 'result.isErr()', file z:/build/build/src/startupcache/StartupCache.cpp, line 173
[task 2019-10-14T22:32:23.057Z] 22:32:23 INFO - PID 11776 | [11776, Main Thread] WARNING: 'result.isErr()', file z:/build/build/src/startupcache/StartupCache.cpp, line 173
[task 2019-10-14T22:32:23.057Z] 22:32:23 INFO - PID 11776 | [11776, Main Thread] WARNING: 'result.isErr()', file z:/build/build/src/startupcache/StartupCache.cpp, line 173
[task 2019-10-14T22:32:23.057Z] 22:32:23 INFO - PID 11776 | [11776, Main Thread] WARNING: 'result.isErr()', file z:/build/build/src/startupcache/StartupCache.cpp, line 173
[task 2019-10-14T22:32:23.057Z] 22:32:23 INFO - PID 11776 | [11776, Main Thread] WARNING: 'result.isErr()', file z:/build/build/src/startupcache/StartupCache.cpp, line 173
[task 2019-10-14T22:32:23.058Z] 22:32:23 INFO - PID 11776 | [11776, Main Thread] WARNING: 'result.isErr()', file z:/build/build/src/startupcache/StartupCache.cpp, line 173
[task 2019-10-14T22:32:23.058Z] 22:32:23 INFO - PID 11776 | [11776, Main Thread] WARNING: 'result.isErr()', file z:/build/build/src/startupcache/StartupCache.cpp, line 173
[task 2019-10-14T22:32:23.059Z] 22:32:23 INFO - PID 11776 | [11776, Main Thread] WARNING: 'result.isErr()', file z:/build/build/src/startupcache/StartupCache.cpp, line 173
[task 2019-10-14T22:32:23.059Z] 22:32:23 INFO - PID 11776 | [11776, Main Thread] WARNING: 'result.isErr()', file z:/build/build/src/startupcache/StartupCache.cpp, line 173
[task 2019-10-14T22:32:23.059Z] 22:32:23 INFO - PID 11776 | [11776, Main Thread] WARNING: 'result.isErr()', file z:/build/build/src/startupcache/StartupCache.cpp, line 173
[task 2019-10-14T22:32:23.060Z] 22:32:23 INFO - PID 11776 | [11776, Main Thread] WARNING: 'result.isErr()', file z:/build/build/src/startupcache/StartupCache.cpp, line 173
[task 2019-10-14T22:32:23.060Z] 22:32:23 INFO - PID 11776 | [11776, Main Thread] WARNING: 'result.isErr()', file z:/build/build/src/startupcache/StartupCache.cpp, line 173
[task 2019-10-14T22:32:23.060Z] 22:32:23 INFO - PID 11776 | [11776, Main Thread] WARNING: 'result.isErr()', file z:/build/build/src/startupcache/StartupCache.cpp, line 173
[task 2019-10-14T22:32:23.060Z] 22:32:23 INFO - PID 11776 | [11776, Main Thread] WARNING: 'result.isErr()', file z:/build/build/src/startupcache/StartupCache.cpp, line 173
[task 2019-10-14T22:32:23.061Z] 22:32:23 INFO - PID 11776 | [11776, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, kKnownEsrVersion) failed with result 0x80004002: file z:/build/build/src/toolkit/components/resistfingerprinting/nsRFPService.cpp, line 661
[task 2019-10-14T22:32:23.061Z] 22:32:23 INFO - (xpcshell/head.js) | test MAIN run_test pending (1)
[task 2019-10-14T22:32:23.061Z] 22:32:23 INFO - (xpcshell/head.js) | test run_next_test 0 pending (2)
[task 2019-10-14T22:32:23.061Z] 22:32:23 INFO - (xpcshell/head.js) | test MAIN run_test finished (2)
[task 2019-10-14T22:32:23.062Z] 22:32:23 INFO - running event loop
[task 2019-10-14T22:32:23.062Z] 22:32:23 INFO - xpcshell-remote.ini:toolkit/components/extensions/test/xpcshell/test_ext_same_site_cookies.js | Starting check_remote
[task 2019-10-14T22:32:23.062Z] 22:32:23 INFO - (xpcshell/head.js) | test check_remote pending (2)
[task 2019-10-14T22:32:23.062Z] 22:32:23 INFO - TEST-PASS | xpcshell-remote.ini:toolkit/components/extensions/test/xpcshell/test_ext_same_site_cookies.js | check_remote - [check_remote : 1]

Hi Erica, I believe this started with bug 1579974, can you please take a look? By the looks of it, this will soon reach the disable recommended queue.

Flags: needinfo?(ewright)
Regressed by: 1579974
Whiteboard: [stockwell needswork:owner]
Keywords: regression

Thank you for flagging me, taking a look

Flags: needinfo?(ewright)

Hi Erica, are there updates here?

Flags: needinfo?(ewright)

Hi, I've been looking into it, There are no updates. I am having trouble relating it to bug 1579974, are there any other possible culprits?

Flags: needinfo?(ewright)

This is reliably reproducing with the changes from bug 1579974 removed, so I am more convinced bug 1579974 is not the cause.

Flags: needinfo?(apavel)

(In reply to Erica Wright [:ewright] from comment #10)

This is reliably reproducing with the changes from bug 1579974 removed, so I am more convinced bug 1579974 is not the cause.

I cannot test that on try because i get hunks failed due to other bugs that landed in the meantime. There are no other possible cuplrits based on retrigger results.

Geoff any suggestions here?

Flags: needinfo?(apavel) → needinfo?(gbrown)

I agree the retriggers in comment 6 appear to blame https://hg.mozilla.org/integration/autoland/rev/adbcc583862cb6831a8821672474f27163fffda5.

Also, I see this stack:

https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=272521227&repo=autoland&lineNumber=6906

[task 2019-10-23T05:52:59.825Z] 05:52:59     INFO -  execute@resource://gre/modules/Sqlite.jsm:564:10
[task 2019-10-23T05:52:59.825Z] 05:52:59     INFO -  execute@resource://gre/modules/Sqlite.jsm:1514:33
[task 2019-10-23T05:52:59.826Z] 05:52:59     INFO -  sumAllEvents@resource://gre/modules/TrackingDBService.jsm:346:28
[task 2019-10-23T05:52:59.826Z] 05:52:59     INFO -  async*saveEvents@resource://gre/modules/TrackingDBService.jsm:291:33
[task 2019-10-23T05:52:59.826Z] 05:52:59     INFO -  Async*callback@resource://gre/modules/Timer.jsm:125:16
[task 2019-10-23T05:52:59.826Z] 05:52:59     INFO -  _execute_test@Z:\\task_1571807279\\build\\tests\\xpcshell\\head.js:659:19

and adbcc583862cb6831a8821672474f27163fffda5 did modify TrackingDBService.jsm.

Maybe :ewright can have a second look?

Flags: needinfo?(gbrown)
Flags: needinfo?(ewright)

I'm looking today again

Flags: needinfo?(ewright)
Attachment #9106258 - Attachment description: Bug 1588645 - Disable test_ext_same_site_cookies.js on e10s win 7 r?#intermittent-reviewers → Bug 1588645 - Disable test_ext_same_site_cookies.js on e10s Win r?#intermittent-reviewers

Currently there are :

  • 17 failures on windows7-32
  • 13 failures on windows10-64
    Modified the patch to disable the test on Win
Flags: needinfo?(gbrown)
Whiteboard: [retriggered][stockwell disable-recommended] → [retriggered]

It looks like ewright is close to fixing this (thanks!); let's hold off on disabling a little longer.

Flags: needinfo?(gbrown)
Pushed by ewright@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0051e7ea0497
Ensure data is saved correctly before database closes on shutdown. r=nhnt11,robwu
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
Assignee: nobody → ewright

Please nominate this for Beta approval when you get a chance.

Flags: needinfo?(ewright)

Comment on attachment 9106799 [details]
Bug 1588645 - Ensure data is saved correctly before database closes on shutdown.

Beta/Release Uplift Approval Request

  • User impact if declined: On closing Firefox some events would try to save to the trackers database after it was already shut down. This ensures waiting entries are saved into the database before shutdown, and any events that are late are thrown away instead of trying to write to a closed database.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Tested on Nightly - data stored in database is still as expected. No other areas of the code are affected by this change.
  • String changes made/needed: none
Flags: needinfo?(ewright)
Attachment #9106799 - Flags: approval-mozilla-beta?

Comment on attachment 9106799 [details]
Bug 1588645 - Ensure data is saved correctly before database closes on shutdown.

Low risk fix for intermittent failures on beta, uplift approved for 71 beta 10, thanks.

Attachment #9106799 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Attachment #9106258 - Attachment is obsolete: true
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: