1588678 - Extensions from distribution/extensions not loaded for mochitest on Mac

Status: RESOLVED FIXED

(Calendar :: General, defect)

Description

[Geoff Lankow (:darktrojan)]

The point of failure could be any one of a number of things here, but I'm posting this in Mochitest since that's what I'm trying to do.

For Thunderbird beta/ESR, Lightning is at distribution/extensions/{e2fda1a4-762b-4020-b5ad-a41df1933103}.xpi. This gets copied into the profile directory at start-up, and everything is fine. Except when it isn't – on Mac mochitest jobs, Lightning never loads and there's no mention of it in the logs, so I presume it is not copied into the profile directory.

This is happening on TaskCluster (example). I haven't got a Mac so I can't test if it happens on a local build.

Comment 1

[Geoff Lankow (:darktrojan)]

I could use some help on this. We're making more and more mochitests so it's becoming more important.

What I don't understand is why it works on Linux and Windows but not on Mac. The file must be packaged correctly since Mozmill tests load Lightning as expected. Is it something to do with how the profile is set up on TC? Is it something OS-specific in Marionette?

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Are you modifying the following preference for the Thunderbird tests?

https://searchfox.org/mozilla-central/rev/55aa17110091deef24b913d033ccaf58f9c6d337/testing/marionette/client/marionette_driver/geckoinstance.py#72

If you don't it shouldn't work at all, so not sure why it is only failing on MacOS. Maybe try with various combinations of the addon specific preferences.

Comment 3

[Geoff Lankow (:darktrojan)]

It seems that's exactly the problem, but as you say, why does it work on Linux and Windows?

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

It might be good to ask some extension folks about it. If the prefs are set to block those extensions it should work cross-platform. Otherwise it smells like a bug to me.

Comment 5

[Geoff Lankow (:darktrojan)]

Attachment: 1588678-calendar-mochitest-1.diff

Comment 6

[Geoff Lankow (:darktrojan)]

Attachment: 1588678-calendar-mochitest-2.diff

Fixed the pref order so I don't grumble later about people who can't put things in order, only to find myself at fault.

Comment 7

[Paul Morris [:pmorris]]

Comment on attachment 9103186 [details] [diff] [review]
1588678-calendar-mochitest-2.diff

Review of attachment 9103186 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/0f8f556acd91
Enable loading of Lightning in mochitest on beta/ESR channels. r=pmorris

Comment 9

[Jorg K (CEST = GMT+2)]

Need Calendar 72 Milestone. Does Philipp still need to do this himself?

Comment 10

[Geoff Lankow (:darktrojan)]

I can't.

Comment 11

[Geoff Lankow (:darktrojan)]

I can't see if this was caused by a problem with the testing infrastructure or with the extensions code itself. CC'ing Andrew, who might be interested.

Comment 12

[Jorg K (CEST = GMT+2)]

TB 71 beta 1:
https://hg.mozilla.org/releases/comm-beta/rev/0649668a52e0ac68c987c542c2afc9cb7cd18012