Closed
Bug 1588680
Opened 5 years ago
Closed 5 years ago
Turn on debug mochitests
Categories
(Thunderbird :: Testing Infrastructure, task, P2)
Thunderbird
Testing Infrastructure
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 71.0
People
(Reporter: darktrojan, Assigned: darktrojan)
References
Details
Attachments
(1 file)
4.45 KB,
patch
|
rjl
:
review+
|
Details | Diff | Splinter Review |
We need debug mochitests before we move all the mozmill tests, or we'll have no debug coverage of any UI stuff. Some things need to be done before then:
- disable the leaked window/docshell warnings
- establish a leak threshold (10MB seems to be a good value right now, eventually this should get lower as we fix leaks… we do fix leaks right?)
- fix or disable a few tests that are causing problems
Updated•5 years ago
|
Priority: -- → P2
Assignee | ||
Updated•5 years ago
|
Assignee: nobody → geoff
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•5 years ago
|
||
This enables debug mochitests with a 10MB leak threshold. I've disabled one test (for debug only) and fixed another.
Attachment #9101994 -
Flags: review?(rob)
Assignee | ||
Comment 2•5 years ago
|
||
If we enable these tests they won't go green without bug 1589305 fixed. But maybe the persistent orange will inspire somebody to find the leaked windows.
Comment 3•5 years ago
|
||
Comment on attachment 9101994 [details] [diff] [review] 1588680-debug-mochitest-1.diff Review of attachment 9101994 [details] [diff] [review]: ----------------------------------------------------------------- Works for me.
Attachment #9101994 -
Flags: review?(rob) → review+
Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/e2e9a71dc663
Turn on debug mochitests with leak threshold at 10MB; r=rjl
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•5 years ago
|
Target Milestone: --- → Thunderbird 71.0
Comment 5•5 years ago
|
||
What a splendid idea to make the tree permanently orange :-(
Pushed by geoff@darktrojan.net: https://hg.mozilla.org/comm-central/rev/5ce8323cabaa Disable browser_todayPane_visibility.js that fails often in debug. rs=bustage-fix
Comment 7•5 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•