1588682 - Change the console execution target to the selected document in the inspector

Status: RESOLVED WORKSFORME

(DevTools :: Console, enhancement, P3)

Description

[capz]

Attachment: Captura de pantalla de 2019-10-14 20-50-45.png

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:69.0) Gecko/20100101 Firefox/69.0

Steps to reproduce:

open https://m.es.aliexpress.com/login.html
open the console (Ctrl + Shift + K)
write document.getElementById('fm-login-id') and press Enter

Actual results:

'null' appeared

Expected results:

a DOM object should have been returned. This is the id of the object reported by the Inspector tool, and it does work in Chromium.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

Hello cplopez, thanks for filing the bug.

So what happen is that the input is in an iframe, and the console evaluation context is the top level document, so we can't target this element directly.

What Chrome is doing though is that it changes the execution context of the console if you select an element in an iframe in the inspector, making this "work".
We might want to do something similar, but we need to work on the UI to make sure we don't confuse the user.

Harald, do you think this could be part of the "target selection" work that we talked about?

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

Attachment: image.png

if that can help you cplopez, you can change the evaluation with the "select an iframe as the currently targeted document" dropdown (you can enable it in the settings menu), or by executing the following command in the console: cd(document.querySelector("iframe"))

Comment 4

[capz]

Yes, that works for me, thank you very much, Nicolas.

The functionality you propose would be very useful too, if added in the future.

Thanks.

Comment 5

[Alexandre Poirot [:ochameau]]

Note that bug 1580165 might fix that, or the other way around.

Comment 6

[:Harald Kirschner :digitarald]

Yes, definitely part of execution context work (implicit context switching)!

Comment 7

[Nicolas Chevobbe [:nchevobbe]]

Bug 1605175 made that work, but only for third parties iframe, which can be confusing for users.

Comment 8

[Nicolas Chevobbe [:nchevobbe]]

with EFT, we now show the context selectors for all frames and selecting a node in an iframe does set its document as the evaluation context