Closed Bug 1588740 Opened 5 years ago Closed 4 years ago

Rewrite the macOS-specific implementation of dump_syms in Rust

Categories

(Toolkit :: Crash Reporting, task)

task
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: gsvelto, Assigned: calixte)

References

(Depends on 1 open bug, Blocks 1 open bug)

Details

This is similar to the work that was done for the Windows dump_syms. This should be only slightly different from the Linux version in bug 1588739 because we would still be dealing with DWARF debug information and name mangling should be the same.

If it's ok for me to work on this low-priority, I'm willing to give this a go.

Flags: needinfo?(gsvelto)

Sure, this isn't urgent so you can take your time. I suggest you check :calixte's rewrite of the Windows version here. Since you should be using the symbolic crates too it might be possible to share some code between the two but I'm not 100% sure. I'll leave it up to you to check if it makes sense to extend that tool or to write a specific one.

Flags: needinfo?(gsvelto)

Calixte, how much of your code is Windows-specific? I see that there's a windows module, but I haven't attempted to dig in too deeply.

Flags: needinfo?(cdenizet)

:Yoric, right now it's almost a windows only code (especially in windows mod).
I think it'd be nice to have common tool for all platforms (it was our goal at least), so if some refactor is needed we're ok with that.
So if you need some access to the repo, please ping me.

Flags: needinfo?(cdenizet)
Assignee: nobody → cdenizet
Status: NEW → ASSIGNED

Already deployed.

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED

The new dump_syms will need to be rewritten to accommodate macOS 10.16/11 Big Sur. See bug 1661771.

Depends on: 1661771

I was wrong, we're still using the old breakpad version of dump_syms, see the Docker configuration file here.

Status: RESOLVED → REOPENED
Resolution: FIXED → ---

Silly me, I mixed up different bugs. This is done, what needs to be done is to adapt the system-symbols-mac task to use the new dump_syms implementation. I'll open a different bug for that.

Status: REOPENED → RESOLVED
Closed: 4 years ago4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.