Closed
Bug 1588782
Opened 5 years ago
Closed 5 years ago
Fix busted getWindowByName calls in GeckoViewContentBlockingController.jsm
Categories
(GeckoView :: General, defect, P3)
Tracking
(firefox70 wontfix, firefox71 wontfix, firefox72 fixed)
RESOLVED
FIXED
mozilla72
People
(Reporter: droeh, Assigned: droeh)
Details
Attachments
(1 file)
We pass this.window to getWindowByName in a few places in GeckoViewContentBlockingController.jsm because this code was originally in a GeckoViewModule, where that is defined -- but it's not defined in the current implementation and only works because of a hack in getWindowByName.
|
||
Comment 1•5 years ago
|
||
Dylan said he would take a look at this bug some time.
Assignee: nobody → droeh
Priority: -- → P3
|
Assignee | |
Comment 2•5 years ago
|
||
Pushed by droeh@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/bfd38a39c33d Fix getWindowByName calls in GeckoViewContentBlockingController.jsm r=snorp
|
||
Comment 4•5 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox72:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
|
|
||
Comment 5•5 years ago
|
||
Dylan, do we need to uplift your getWindowByName fix to GV 71 Beta?
|
|
Assignee | |
Comment 6•5 years ago
|
||
(In reply to Chris Peterson [:cpeterson] from comment #5)
Dylan, do we need to uplift your getWindowByName fix to GV 71 Beta?
Nope, this doesn't actually change behavior, just cleans something up a bit.
Flags: needinfo?(droeh)
|
|
||
Updated•5 years ago
|
|
|
||
Comment 7•2 years ago
|
||
Move GeckoView::Tracking Protection bugs to the GeckoView::General component.
Component: Tracking Protection → General
You need to log in
before you can comment on or make changes to this bug.
Description
•