The fav icon of a webpage doesn't appear on the bookmark toolbar after bookmarking it. It only appears after reopening the browser
Categories
(Firefox :: Private Browsing, defect, P5)
Tracking
()
People
(Reporter: joelraju, Unassigned)
References
Details
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:70.0) Gecko/20100101 Firefox/70.0
Steps to reproduce:
Visit https://send.firefox.com.
Bookmark this page and add to toolbar. The favicon doesn't show up.
Firefox Developer Edition 70.0b14 (64-bit)
MacOS 10.14.6
Actual results:
Instead of having the favicon from the website it shows a generic globe favicon.
Expected results:
The favicon for the actual website should have shown.
More info - I created the bookmark from a Private browsing window.
|
||
Comment 2•6 years ago
|
||
Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:69.0) Gecko/20100101 Firefox/69.0
Hi,
I have managed to reproduce this issue on Firefox Developer Edition 70.0b14, latest FF release (69.0.3) and latest Nightly build 71.0a1 (2019-10-20) using Mac OS 10.14 and Windows 10.
Further, I will move this over to a component so developers can take a look over it. If is not the correct component please feel free to change it to an appropriate one.
The issue is not reproducible if the user bookmark the page from the normal window. The issue occurs just from the private browsing.
Thanks for the report.
|
||
Comment 4•6 years ago
|
||
in PB mode favicons are only stored for bookmarks, the problem here is that when you first visit the page it's not a bookmark, after you add the bookmark we don't have a favicon because it was not stored originally.
We should probably reissue the favicon store message when the page is bookmarked. May not be cheap to do, and the workaround is not too bad anyway.
|
||
Comment 5•6 years ago
|
||
Just to add to this bug as you dupped bug 1273604 here, in case of private browsing favs, favicon is never registered later on. Restarting browser don't change a thing.
|
|
||
Comment 6•6 years ago
|
||
That depends on the specific page and where the favicon is stored, in certain cases it may be complicate to figure out if storing a certain icon is "safe" from a privacy point of view.
|
|
||
Comment 7•6 years ago
|
||
(In reply to Marco Bonardo [::mak] from comment #6)
That depends on the specific page and where the favicon is stored, in certain cases it may be complicate to figure out if storing a certain icon is "safe" from a privacy point of view.
What could the danger be? Because if the user decides to add the page as a favorite, I guess he's perfectly aware that it's gonna result in some traces in the browser, you can't do it another way.
|
|
||
Comment 8•6 years ago
|
||
the risk is that the page at domain1.com uses a favicon at domain2.com, and then we are storing data for 2 domains, with an higher possibility of "leaking" data for the domain not connected to the page. In practice the risk of a bug in removing/handling orphan information for domains increases.
|
||
Updated•6 years ago
|
|
||
Updated•3 years ago
|
|
||
Comment 9•3 years ago
|
||
The issue is still reproducible in the latest nightly Fx108.0a1, latest beta Fx107.0b4 and latest RC Fx 106.0.1, but under slightly different conditions.
In the normal window, the bookmark has a favicon, but in private browsing mode, the bookmarks will have a favicon in one session. ANY bookmark added in a PBM window will be missing the favicon, even if the websited is visited multiple times.
The favicon for bookmarks appears ONLY if:
- a new private window is opened and the website is refreshed in the first PB window where the website was opened
- the current PB window is closed and another is opened and the website is visited
Updating the flags accordingly.
Description
•