Closed Bug 1588815 Opened 1 year ago Closed 10 months ago

[wpt-sync] Sync PR 19703 - Fetch Metadata: deprecate `nested-navigate` mode.

Categories

(Core :: DOM: Networking, task, P5)

task

Tracking

()

RESOLVED FIXED
mozilla72
Tracking Status
firefox72 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [necko-triaged][wptsync downstream])

Attachments

(2 files)

Sync web-platform-tests PR 19703 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/19703
Details from upstream follow.

Yifan Luo <lyf@google.com> wrote:

Fetch Metadata: deprecate nested-navigate mode.

As discussed in
https://github.com/w3c/webappsec-fetch-metadata/issues/45,

We have decided to shift the model around nested navigations from
exposure via the request's mode to its destination. This patch
shift the nested-navigate mode to two parts:

  • navigate for frame and iframe.
  • no-cors for object.

Change-Id: I09a2be6b41547f6eeb1e308416234a40f0c9b5b3
Reviewed-on: https://chromium-review.googlesource.com/1862690
WPT-Export-Revision: 2d438b92995e9ce074ea8da3eef52b7f4461210d

PR 19703 applied with additional changes from upstream: 643548a2e0cef9324a67e61534d2105c8e6b4c34, e6ca5a0decb3db94d808eeb7c0c0688196b0bbd1
Component: web-platform-tests → DOM: Networking
Product: Testing → Core
Priority: P4 → P5
Whiteboard: [wptsync downstream] → [necko-triaged][wptsync downstream]
Result changes from PR not available.

GitHub CI Results

wpt.fyi PR Results Base Results

Ran 3 tests and 13 subtests

Firefox

OK : 2
PASS : 3
FAIL : 7
TIMEOUT: 4

Chrome

OK : 2
PASS : 3
FAIL : 7
TIMEOUT: 4

Safari

OK : 1
PASS : 3
FAIL : 4
TIMEOUT: 8

Gecko CI Results

Ran 3 tests and 13 subtests
OK : 2
PASS : 3
FAIL : 7
TIMEOUT: 4

New tests that don't pass

/fetch/metadata/iframe.tentative.https.sub.html
web-platform.test -> web-platform.test:8443 iframe: forced: FAIL
web-platform.test -> web-platform.test:8443 iframe: user-activated: FAIL
web-platform.test -> www.not-web-platform.test:8443 iframe: forced: FAIL
web-platform.test -> www.not-web-platform.test:8443 iframe: user-activated: FAIL
web-platform.test -> www.web-platform.test:8443 iframe: forced: FAIL
web-platform.test -> www.web-platform.test:8443 iframe: user-activated: FAIL
/fetch/metadata/iframe.tentative.sub.html
Secure, cross-site (cross-scheme, same-host) iframe: FAIL
/fetch/metadata/portal.tentative.https.sub.html: TIMEOUT
web-platform.test -> web-platform.test:8443 portal: TIMEOUT
web-platform.test -> www.not-web-platform.test:8443 portal: TIMEOUT
web-platform.test -> www.web-platform.test:8443 portal: TIMEOUT

Automatic update from web-platform-tests
Fetch Metadata: deprecate nested-navigate mode.

As discussed in
https://github.com/w3c/webappsec-fetch-metadata/issues/45,

We have decided to shift the model around nested navigations from
exposure via the request's mode to its destination. This patch
shift the nested-navigate mode to two parts:

  • navigate for frame and iframe.
  • no-cors for object.

Change-Id: I09a2be6b41547f6eeb1e308416234a40f0c9b5b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862690
Commit-Queue: Yifan Luo <lyf@google.com>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709478}

--

wpt-commits: 2eebdd2f37758cdd94c0c2bddc70763862ef283f
wpt-pr: 19703

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/882f13426698
[wpt PR 19703] - Fetch Metadata: deprecate `nested-navigate` mode., a=testonly
https://hg.mozilla.org/integration/autoland/rev/e7ca863c9920
[wpt PR 19703] - Update wpt metadata, a=testonly
Status: NEW → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
You need to log in before you can comment on or make changes to this bug.