Closed Bug 1588922 Opened 6 months ago Closed 4 months ago

New whitespace badge design - small tweak to alignment

Categories

(DevTools :: Inspector, enhancement, P3)

enhancement

Tracking

(firefox72 fixed)

RESOLVED FIXED
Firefox 72
Tracking Status
firefox72 --- fixed

People

(Reporter: victoria, Assigned: thomas.jean.lynch)

References

Details

Attachments

(1 file)

Let's tweak the alignment of the badge so that it's flush with other tags. (Aligned at the left edges instead of indented.) Last time I looked at this, this worked:

Horizontally align badge with its peer nodes by removing padding from .editor.text .whitespace and removing margin from .editor.text .whitespace::before

Blocks: 1568847

Thanks for filing Victoria.

Jean, would you be interested in picking up this small follow up to your work in Bug 1568847?

Flags: needinfo?(thomas.jean.lynch)

Yeah, I'll grab this bug.

Flags: needinfo?(thomas.jean.lynch)

Great, thank you so much! Assigning it to you :)

Assignee: nobody → thomas.jean.lynch
Status: NEW → ASSIGNED
Priority: -- → P3

Tweaked the alignment of the whitespace badge so it is flush with other tags.

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:thomas.jean.lynch, could you have a look please?
For more information, please visit auto_nag documentation.

Flags: needinfo?(thomas.jean.lynch)

Sorry I missed the last r+ from Victoria. Queued for landing now.

Flags: needinfo?(thomas.jean.lynch)
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/acbeadae8404
Tweak alignment of whitespace badge. r=jdescottes,victoria
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 72
You need to log in before you can comment on or make changes to this bug.