1588931 - [translate] Localize Machinery sources

Status: RESOLVED FIXED

(Webtools Graveyard :: Pontoon, enhancement, P3)

Description

[Matjaz Horvat [:mathjazz]]

Attachment: Screenshot 2019-10-16 at 00.25.56.png

The Machinery sources and their title attributes in the Machinery tab need to be localized (except Company names and Trademarks).

This bug covers:

• wrapping the unlocalized strings in <Localized> components;
• giving them proper l10n IDs;
• adding the content to the en-US reference .ftl file;
• building the docker image (make shell) and verifying, using pseudo-localization, that the content is now localized.

The JS file is:
frontend/src/core/api/machinery.js

The localization file is:
frontend/public/static/locales/en-US/translate.ftl

Please note that this is a Translate.Next bug. More instructions must be followed in order to be able to work on it locally: https://github.com/mozilla/pontoon/blob/master/frontend/README.md

Comment 1

[Nadinda Rachmat [:nadinda]]

Should I try to get this one done?

Comment 2

[Matjaz Horvat [:mathjazz]]

Assigned!

Comment 3

[Nadinda Rachmat [:nadinda]]

Attachment: machinery.png

Comment 4

[Nadinda Rachmat [:nadinda]]

hi :mathjazz

I have trouble locating your screenshot. Is it in machinery tab on translation menu? Because I all can see is like on my attached screenshot. I also have difficulty on how to wrap the <Localized /> tag. Because the string is inside the property of an object.

And when I looked at the JS file you refer to frontend/src/core/api/machinery.js sometimes sources.type is translatable (without company names & trademarks) like the one on this :
https://github.com/mozilla/pontoon/blob/6f42e4197cff1d79828b6996ac45458439d4f0a8/frontend/src/core/api/machinery.js#L45

But on the same property of sources.type it has company name like this one :
https://github.com/mozilla/pontoon/blob/6f42e4197cff1d79828b6996ac45458439d4f0a8/frontend/src/core/api/machinery.js#L75

So, can you please give me hints what should I do to make it localizable?

Comment 5

[Matjaz Horvat [:mathjazz]]

Yes, this is the Machinery tab. Are you confused because you don't see Translation Memory entries? Try to submit a translation to one of the two strings that are the same (or almost the same) and observe the Machinery tab when you open the other one. Maybe "a string" and "a strong" would do.

Check out how we localize notifications, maybe that will give you a hint on how you can localize:
https://github.com/mozilla/pontoon/blob/6f42e4197cff1d79828b6996ac45458439d4f0a8/frontend/src/core/notification/messages.js

The only localizable sources.type is "Translation Memory".

All sources.title are localizable.

Comment 6

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/pontoon/pull/1441

Comment 7

[[DEACTIVATED] Adrian Gaudebert]

adngdb merged PR #1441: "[WIP] Fix Bug 1588931 - Localize Machinery sources" in 8a3e4d8.