1588993 - Crash in [@ mozilla::ipc::MessageChannel::Send | mozilla::dom::PContentChild::SendInitOtherFamilyNames]

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, defect, P2)

Description

[blinky]

Steps to reproduce:

1. Set gfx.e10s.font-list.shared to true.
2. Restart Firefox.
3. Download Font Loader.
4. Download Franklin Gothic Book Regular.ttf.
5. Open this page.
6. Open the Font Loader, Click on the Add Fonts button, Select the font file Franklin Gothic Book Regular.ttf then click Open.
7. Click on the Load button.

Actual results:

The tab crashed.
This also happens on startup.

Crash report: bp-cdb19dfa-e476-4433-9b62-b02000191016

Top 10 frames of crashing thread:

0 xul.dll mozilla::ipc::MessageChannel::Send ipc/glue/MessageChannel.cpp
1 xul.dll mozilla::dom::PContentChild::SendInitOtherFamilyNames ipc/ipdl/PContentChild.cpp:5685
2 xul.dll void gfxPlatformFontList::InitOtherFamilyNames gfx/thebes/gfxPlatformFontList.cpp:531
3 xul.dll gfxPlatformFontList::FindAndAddFamilies gfx/thebes/gfxPlatformFontList.cpp:970
4 xul.dll gfxDWriteFontList::FindAndAddFamilies gfx/thebes/gfxDWriteFontList.cpp:1703
5 xul.dll void gfxFontGroup::AddPlatformFont gfx/thebes/gfxTextRun.cpp:1762
6 xul.dll gfxFontGroup::BuildFontList gfx/thebes/gfxTextRun.cpp:1713
7 xul.dll gfxFontGroup::gfxFontGroup gfx/thebes/gfxTextRun.cpp:1696
8 xul.dll nsFontMetrics::nsFontMetrics gfx/src/nsFontMetrics.cpp:133
9 xul.dll nsFontCache::GetMetricsFor gfx/src/nsDeviceContext.cpp:178

Comment 1

[Jonathan Kew [:jfkthame]]

This reproduced for me on macOS as well. It's doing IPC from a stylo thread, which is a no-no.

Comment 2

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1588993 - Don't send InitOtherFamilyNames IPC message from a stylo thread; post a runnable to the main thread instead. r=jwatt

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/960aac09a135
Don't send InitOtherFamilyNames IPC message from a stylo thread; post a runnable to the main thread instead. r=jwatt

Comment 4

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/960aac09a135