Closed Bug 1588997 Opened Last month Closed Last month

Convert ObjectClient to protocol.js front

Categories

(DevTools :: Framework, task, P1)

task

Tracking

(firefox71 fixed)

RESOLVED FIXED
Firefox 71
Tracking Status
firefox71 --- fixed

People

(Reporter: nchevobbe, Assigned: jarilvalenciano, NeedInfo)

References

(Blocks 3 open bugs)

Details

(Whiteboard: dt-fission)

Attachments

(1 file)

No description provided.
Blocks: 1529916
Blocks: 1588999
Component: Shared Components → Framework
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/29bc3ebe8b4e
Convert ObjectClient to protocol.js front. r=nchevobbe.

Backed out changeset 29bc3ebe8b4e (bug 1588997) for browser_ext_devtools_panels_elements_sidebar.js && browser_ext_find.js failures

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=browser-chrome-e10s&fromchange=ac0dbc5ab461ddeb39c7a853dbb0e14644afe4e6&tochange=85664ffdf668cbe75f0ed42b5f4365158f6a4622&selectedJob=271653469

Backout link: https://hg.mozilla.org/integration/autoland/rev/c3bfb7519ae9

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=271653469&repo=autoland&lineNumber=2192

[task 2019-10-17T07:10:42.380Z] 07:10:42 INFO - Test extension inspector sidebar 2 (sidebar.setObject without a root title)
[task 2019-10-17T07:10:42.383Z] 07:10:42 INFO - TEST-PASS | browser/components/extensions/test/browser/browser_ext_devtools_panels_elements_sidebar.js | Got the shown event on the second extension sidebar -
[task 2019-10-17T07:10:42.383Z] 07:10:42 INFO - TEST-PASS | browser/components/extensions/test/browser/browser_ext_devtools_panels_elements_sidebar.js | Got the hidden event on the first extension sidebar -
[task 2019-10-17T07:10:42.384Z] 07:10:42 INFO - TEST-PASS | browser/components/extensions/test/browser/browser_ext_devtools_panels_elements_sidebar.js | Got the expected title on the active sidebar tab -
[task 2019-10-17T07:10:42.384Z] 07:10:42 INFO - TEST-PASS | browser/components/extensions/test/browser/browser_ext_devtools_panels_elements_sidebar.js | Got a rendered sidebar panel for the second registered extension sidebar -
[task 2019-10-17T07:10:42.385Z] 07:10:42 INFO - TEST-PASS | browser/components/extensions/test/browser/browser_ext_devtools_panels_elements_sidebar.js | The sidebar panel contains a rendered TreeView component -
[task 2019-10-17T07:10:42.385Z] 07:10:42 INFO - TEST-PASS | browser/components/extensions/test/browser/browser_ext_devtools_panels_elements_sidebar.js | The TreeView component contains the expected a cell of type number -
[task 2019-10-17T07:10:42.386Z] 07:10:42 INFO - Test extension inspector sidebar 3 (sidebar.setObject with a root title)
[task 2019-10-17T07:10:42.386Z] 07:10:42 INFO - TEST-PASS | browser/components/extensions/test/browser/browser_ext_devtools_panels_elements_sidebar.js | Got the shown event on the second extension sidebar -
[task 2019-10-17T07:10:42.387Z] 07:10:42 INFO - TEST-PASS | browser/components/extensions/test/browser/browser_ext_devtools_panels_elements_sidebar.js | Got the hidden event on the first extension sidebar -
[task 2019-10-17T07:10:42.387Z] 07:10:42 INFO - TEST-PASS | browser/components/extensions/test/browser/browser_ext_devtools_panels_elements_sidebar.js | Got the expected title on the active sidebar tab -
[task 2019-10-17T07:10:42.388Z] 07:10:42 INFO - TEST-PASS | browser/components/extensions/test/browser/browser_ext_devtools_panels_elements_sidebar.js | Got a rendered sidebar panel for the third registered extension sidebar -
[task 2019-10-17T07:10:42.389Z] 07:10:42 INFO - TEST-PASS | browser/components/extensions/test/browser/browser_ext_devtools_panels_elements_sidebar.js | The sidebar panel contains a rendered TreeView component -
[task 2019-10-17T07:10:42.390Z] 07:10:42 INFO - TEST-PASS | browser/components/extensions/test/browser/browser_ext_devtools_panels_elements_sidebar.js | The TreeView component contains the expected a cell of type string -
[task 2019-10-17T07:10:42.390Z] 07:10:42 INFO - TEST-PASS | browser/components/extensions/test/browser/browser_ext_devtools_panels_elements_sidebar.js | The optional root object title has been included in the object tree -
[task 2019-10-17T07:10:42.390Z] 07:10:42 INFO - Unloading the extension and check that all the sidebar have been removed
[task 2019-10-17T07:10:42.393Z] 07:10:42 INFO - TEST-PASS | browser/components/extensions/test/browser/browser_ext_devtools_panels_elements_sidebar.js | Got the shown event on the third extension sidebar -
[task 2019-10-17T07:10:42.393Z] 07:10:42 INFO - TEST-PASS | browser/components/extensions/test/browser/browser_ext_devtools_panels_elements_sidebar.js | Got the hidden event on the second extension sidebar -
[task 2019-10-17T07:10:42.394Z] 07:10:42 INFO - TEST-PASS | browser/components/extensions/test/browser/browser_ext_devtools_panels_elements_sidebar.js | Got the expected title on the active sidebar tab -
[task 2019-10-17T07:10:42.394Z] 07:10:42 INFO - TEST-PASS | browser/components/extensions/test/browser/browser_ext_devtools_panels_elements_sidebar.js | All the registered sidebars have been unregistered on extension unload -
[task 2019-10-17T07:10:42.395Z] 07:10:42 INFO - TEST-PASS | browser/components/extensions/test/browser/browser_ext_devtools_panels_elements_sidebar.js | The first registered sidebar has been removed -
[task 2019-10-17T07:10:42.395Z] 07:10:42 INFO - TEST-PASS | browser/components/extensions/test/browser/browser_ext_devtools_panels_elements_sidebar.js | The second registered sidebar has been removed -
[task 2019-10-17T07:10:42.396Z] 07:10:42 INFO - TEST-PASS | browser/components/extensions/test/browser/browser_ext_devtools_panels_elements_sidebar.js | The third registered sidebar has been removed -
[task 2019-10-17T07:10:42.396Z] 07:10:42 INFO - TEST-PASS | browser/components/extensions/test/browser/browser_ext_devtools_panels_elements_sidebar.js | The third registered sidebar has been removed -
[task 2019-10-17T07:10:42.397Z] 07:10:42 INFO - Test that all the objectValueGrip actors have been released
[task 2019-10-17T07:10:42.397Z] 07:10:42 INFO - Buffered messages finished
[task 2019-10-17T07:10:42.398Z] 07:10:42 INFO - TEST-UNEXPECTED-FAIL | browser/components/extensions/test/browser/browser_ext_devtools_panels_elements_sidebar.js | Test timed out -
[task 2019-10-17T07:10:42.399Z] 07:10:42 INFO - GECKO(1156) | MEMORY STAT | vsize 20975964MB | residentFast 1862MB
[task 2019-10-17T07:10:42.400Z] 07:10:42 INFO - TEST-OK | browser/components/extensions/test/browser/browser_ext_devtools_panels_elements_sidebar.js | took 90198ms
[task 2019-10-17T07:10:42.400Z] 07:10:42 INFO - Not taking screenshot here: see the one that was previously logged
[task 2019-10-17T07:10:42.401Z] 07:10:42 INFO - TEST-UNEXPECTED-FAIL | browser/components/extensions/test/browser/browser_ext_devtools_panels_elements_sidebar.js | Found a tab after previous test timed out: http://mochi.test:8888/ -
[task 2019-10-17T07:10:42.401Z] 07:10:42 INFO - checking window state
[task 2019-10-17T07:10:42.563Z] 07:10:42 INFO - Not taking screenshot here: see the one that was previously logged
[task 2019-10-17T07:10:42.564Z] 07:10:42 INFO - TEST-UNEXPECTED-FAIL | browser/components/extensions/test/browser/browser_ext_devtools_panels_elements_sidebar.js | Uncaught exception received from previously timed out test - [object Object]
[task 2019-10-17T07:10:42.621Z] 07:10:42 INFO - TEST-START | browser/components/extensions/test/browser/browser_ext_find.js
[task 2019-10-17T07:10:42.648Z] 07:10:42 INFO - GECKO(1156) | JavaScript error: , line 0: uncaught exception: Object
[task 2019-10-17T07:10:44.430Z] 07:10:44 INFO - Not taking screenshot here: see the one that was previously logged
[task 2019-10-17T07:10:44.431Z] 07:10:44 INFO - Buffered messages logged at 07:10:42
[task 2019-10-17T07:10:44.431Z] 07:10:44 INFO - Entering test bound testFind
...
[task 2019-10-17T07:10:44.514Z] 07:10:44 INFO - Test that rangeData is not returned if includeRangeData is false.
[task 2019-10-17T07:10:44.517Z] 07:10:44 INFO - TEST-PASS | browser/components/extensions/test/browser/browser_ext_find.js | The boolean cast value of rangeData: - Expected: false, Actual: false -
[task 2019-10-17T07:10:44.518Z] 07:10:44 INFO - Test that rectData is not returned if includeRectData is false.
[task 2019-10-17T07:10:44.519Z] 07:10:44 INFO - TEST-PASS | browser/components/extensions/test/browser/browser_ext_find.js | The boolean cast value of rectData: - Expected: false, Actual: false -
[task 2019-10-17T07:10:44.520Z] 07:10:44 INFO - Test that text spanning multiple inline elements is found.
[task 2019-10-17T07:10:44.521Z] 07:10:44 INFO - TEST-PASS | browser/components/extensions/test/browser/browser_ext_find.js | The number of matches found: - Expected: 1, Actual: 1 -
[task 2019-10-17T07:10:44.522Z] 07:10:44 INFO - Test that text spanning multiple block elements is not found.
[task 2019-10-17T07:10:44.528Z] 07:10:44 INFO - Buffered messages logged at 07:10:44
[task 2019-10-17T07:10:44.529Z] 07:10:44 INFO - TEST-PASS | browser/components/extensions/test/browser/browser_ext_find.js | The number of matches found: - Expected: 0, Actual: 0 -
[task 2019-10-17T07:10:44.530Z] 07:10:44 INFO - Test that highlightResults returns proper status code.
[task 2019-10-17T07:10:44.531Z] 07:10:44 INFO - TEST-PASS | browser/components/extensions/test/browser/browser_ext_find.js | Promise rejected, expecting rejection to match /index supplied was out of range/, got "index supplied was out of range": rejected Promise should pass the expected error -
[task 2019-10-17T07:10:44.532Z] 07:10:44 INFO - TEST-PASS | browser/components/extensions/test/browser/browser_ext_find.js | Promise rejected, expecting rejection to match /no search results to highlight/, got "no search results to highlight": rejected Promise should pass the expected error -
[task 2019-10-17T07:10:44.533Z] 07:10:44 INFO - Test that text was highlighted properly.
[task 2019-10-17T07:10:44.534Z] 07:10:44 INFO - TEST-PASS | browser/components/extensions/test/browser/browser_ext_find.js | The text that was highlighted: - Expected: bananA, Actual: bananA -
[task 2019-10-17T07:10:44.535Z] 07:10:44 INFO - Test that rectangle data returned from the search matches the highlighted result.
[task 2019-10-17T07:10:44.538Z] 07:10:44 INFO - TEST-PASS | browser/components/extensions/test/browser/browser_ext_find.js | rect.top: - Expected: 160, Actual: 160 -
[task 2019-10-17T07:10:44.539Z] 07:10:44 INFO - TEST-PASS | browser/components/extensions/test/browser/browser_ext_find.js | rect.left: - Expected: 28, Actual: 28 -
[task 2019-10-17T07:10:44.540Z] 07:10:44 INFO - Buffered messages finished
[task 2019-10-17T07:10:44.541Z] 07:10:44 INFO - TEST-UNEXPECTED-FAIL | browser/components/extensions/test/browser/browser_ext_find.js | A promise chain failed to handle a rejection: 'release' active request packet to 'server0.conn30.child1/obj39' can't be sent as the connection just closed. - stack: listenerJson@resource://devtools/shared/client/debugger-client.js:346:17
[task 2019-10-17T07:10:44.542Z] 07:10:44 INFO - emit@resource://devtools/shared/event-emitter.js:190:24
[task 2019-10-17T07:10:44.543Z] 07:10:44 INFO - emit@resource://devtools/shared/event-emitter.js:271:18
[task 2019-10-17T07:10:44.544Z] 07:10:44 INFO - reject@resource://devtools/shared/client/debugger-client.js:820:15
[task 2019-10-17T07:10:44.545Z] 07:10:44 INFO - purgeRequests/<@resource://devtools/shared/client/debugger-client.js:841:53
[task 2019-10-17T07:10:44.546Z] 07:10:44 INFO - purgeRequests@resource://devtools/shared/client/debugger-client.js:841:28
[task 2019-10-17T07:10:44.546Z] 07:10:44 INFO - onClosed@resource://devtools/shared/client/debugger-client.js:767:10
[task 2019-10-17T07:10:44.547Z] 07:10:44 INFO - close@resource://devtools/shared/transport/local-transport.js:171:20
[task 2019-10-17T07:10:44.548Z] 07:10:44 INFO - close@resource://devtools/shared/transport/local-transport.js:167:13
[task 2019-10-17T07:10:44.549Z] 07:10:44 INFO - close@resource://devtools/shared/transport/local-transport.js:167:13
[task 2019-10-17T07:10:44.550Z] 07:10:44 INFO - cleanup@resource://devtools/shared/client/debugger-client.js:220:27
[task 2019-10-17T07:10:44.551Z] 07:10:44 INFO - close/promise<@resource://devtools/shared/client/debugger-client.js:236:7
[task 2019-10-17T07:10:44.551Z] 07:10:44 INFO - close@resource://devtools/shared/client/debugger-client.js:213:21
[task 2019-10-17T07:10:44.552Z] 07:10:44 INFO - TargetMixin/destroy/this._destroyer<@resource://devtools/shared/fronts/targets/target-mixin.js:468:32
[task 2019-10-17T07:10:44.553Z] 07:10:44 INFO - destroy@resource://devtools/shared/fronts/targets/target-mixin.js:493:9
[task 2019-10-17T07:10:44.554Z] 07:10:44 INFO - destroy@resource://devtools/shared/fronts/targets/browsing-context.js:153:27
[task 2019-10-17T07:10:44.555Z] 07:10:44 INFO - _destroyToolbox/onceDestroyed</<@resource://devtools/client/framework/toolbox.js:3699:27
[task 2019-10-17T07:10:44.556Z] 07:10:44 INFO - promise callback*_destroyToolbox/onceDestroyed<@resource://devtools/client/framework/toolbox.js:3659:12
[task 2019-10-17T07:10:44.556Z] 07:10:44 INFO - _destroyToolbox@resource://devtools/client/framework/toolbox.js:3655:27
[task 2019-10-17T07:10:44.557Z] 07:10:44 INFO - destroy@resource://devtools/client/framework/toolbox.js:3537:28
...

ps: for some reason, the backout push didn't show up in treeherder so, we can check the backout here: https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=browser-chrome-e10s&revision=85664ffdf668cbe75f0ed42b5f4365158f6a4622

Flags: needinfo?(jarilvalenciano)
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a15ba287ac6f
Convert ObjectClient to protocol.js front. r=nchevobbe.
Status: ASSIGNED → RESOLVED
Closed: Last month
Resolution: --- → FIXED
Target Milestone: --- → Firefox 71
You need to log in before you can comment on or make changes to this bug.