Closed Bug 1589038 Opened 3 years ago Closed 3 years ago

The scrollbars are wrongly inactive when horizontally resizing the browser under 25% while the onboarding modal is displayed

Categories

(Firefox :: Messaging System, defect, P1)

defect

Tracking

()

VERIFIED FIXED
Firefox 72
Iteration:
73.2 - Dec 16 - Jan 5
Tracking Status
firefox-esr68 --- unaffected
firefox69 --- unaffected
firefox70 --- wontfix
firefox71 --- wontfix
firefox72 --- wontfix
firefox73 --- verified

People

(Reporter: acupsa, Assigned: emcminn)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: regression)

Attachments

(2 files)

Attached image Browser resize.gif

[Affected versions]:

  • Firefox Nightly 71.0a1, Build ID: 20191015213743
  • Firefox Release Candidate 70, Build ID:20191014163058

[Affected Platforms]:

  • All Windows
  • All Mac
  • All Linux

[Steps to reproduce]:

  1. Open the Firefox Browser and navigate to the “about:welcome” page.
  2. Horizontally resize the browser below 25%.
  3. Observe the displayed scrollbars.

[Expected result]:

  • The displayed scrollbars are active.

[Actual result]:

  • The displayed scrollbars are inactive.

[Regression Range]:

It seems like this issue was introduced with this export and possibly by this bug 1563741.

[Notes]:

  • I’ve attached a screen recording with the issue.

@Emilio, could you please take a look at this?

Flags: needinfo?(emilio)

That regression range is necessarily wrong, that patch only touched tests.

Flags: needinfo?(emilio) → needinfo?(acupsa)

@Emilio, I will run a new regression range on a different OS.

Flags: needinfo?(acupsa)
Regressed by: 1567243
No longer regressed by: 1567349

That makes much more sense :)

@Emilio, sorry about this.
I rerun the regression range on Windows 10x 64 and reached the same pushlog. However, on MacOS I've reached a different regression range:

11:02.43 INFO: Last good revision: 0bbd8e64cb9cbef70d12bcf502a8948882b63fe9
11:02.43 INFO: First bad revision: 16d1399f602c8a336e8f6e7a160f0e698aff486d
11:02.43 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=0bbd8e64cb9cbef70d12bcf502a8948882b63fe9&tochange=16d1399f602c8a336e8f6e7a160f0e698aff486d

It seems like this issue was introduced with this export and possibly by this bug 1563741.

I've also updated the initial bug with this information.

@Ed, could you please take a look at this?

Flags: needinfo?(edilee)
Summary: The scrollbars are wrongly inactive when horizontally resizing the browsing under 25% while the onboarding modal is displayed → The scrollbars are wrongly inactive when horizontally resizing the browser under 25% while the onboarding modal is displayed

Discussed during triage, marking as won't fix for 70 per discussion.

Tim, could you triage this regression wrt to our upcoming releases? Thanks

Flags: needinfo?(tspurway)

Aaron, could you weigh in on how important this regression is from a UX perspective? How "bad" is this for the user - is it a "must fix asap", "nice to have" or "edge case" or some other granularity of importance?

Flags: needinfo?(edilee) → needinfo?(abenson)

I'd say this is a "must fix asap" since it could have negative repercussions for successfully navigating the page at a critical part of the user journey.

Flags: needinfo?(abenson)
Assignee: nobody → emcminn
Iteration: --- → 73.2 - Dec 16 - Jan 5
Flags: needinfo?(tspurway)
Priority: -- → P1
Target Milestone: --- → Firefox 72

Is it possible that this is a Windows-only bug? I've been unable to reproduce it locally. (on Mac) Thanks!

Flags: needinfo?(acupsa)

Mac by default hides scrollbars unless scrolling or keyboard/mouse are plugged in. You can change your System Preferences -> General -> Show scroll bars

Flags: needinfo?(acupsa)

(In reply to Ed Lee :Mardak from comment #10)

Mac by default hides scrollbars unless scrolling or keyboard/mouse are plugged in. You can change your System Preferences -> General -> Show scroll bars

My scrollbars are visible & working as expected - I can't duplicate the inactive scrollbars at 25% width.

Can you click on the scrollbars or are you using the "scrollwheel" / "scroll" gesture?

Flags: needinfo?(emcminn)

(In reply to Ed Lee :Mardak from comment #12)

Can you click on the scrollbars or are you using the "scrollwheel" / "scroll" gesture?

Both work for me!

Flags: needinfo?(emcminn)
Flags: needinfo?(acupsa)

@Emily, I have retested this issue and I can confirm that is reproducible on all OS-es (Windows, Mac, and Linux). I also tested the issue on a Macbook Air 10.14.6.
As Ed specified in Comment 10 the "Show scroll bars" option was set to "Always" and the scrollbars are displayed as inactive.
However, if the "Show scroll bars" option is set to "When scrolling", the scrollbars are not displayed at all.

Flags: needinfo?(acupsa)

Thanks, @Andreea! I've been able to duplicate it now - for me "Always" will duplicate the bug, but "when scrolling" seems to have the correct behavior. I'll try to find a solution that works for both :)

Scrollbars are now correctly active and clickable at less than 25% of window size, regardless of the system settings for scrollbars.

This seems to have been awaiting review for a couple of weeks?

Flags: needinfo?(edilee)

Added review comments requiring changes

Attachment #9112336 - Attachment description: Bug 1589038 - Fixed incorrect scrollbar behaviour → Bug 1589038 - Allow about:welcome modal scrollbars to be clicked on narrow windows
Pushed by elee@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0d526197ba71
Allow about:welcome modal scrollbars to be clicked on narrow windows r=Mardak
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED

I have verified that this issue is no longer reproducible on Firefox Nightly 73.0a1 (Build ID: 20191219095006) on Windows 10 x64, Mac 10.14.6 and Ubuntu 18.04.2. The scrollbars are active when the browser is minimized below 25%.

Status: RESOLVED → VERIFIED
Regressions: 1612108
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.