1589038 - The scrollbars are wrongly inactive when horizontally resizing the browser under 25% while the onboarding modal is displayed

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect, P1)

Description

[Andreea Cupsa [:acupsa], Experiments QA]

Attachment: Browser resize.gif

[Affected versions]:

• Firefox Nightly 71.0a1, Build ID: 20191015213743
• Firefox Release Candidate 70, Build ID:20191014163058

[Affected Platforms]:

• All Windows
• All Mac
• All Linux

[Steps to reproduce]:

1. Open the Firefox Browser and navigate to the “about:welcome” page.
2. Horizontally resize the browser below 25%.
3. Observe the displayed scrollbars.

[Expected result]:

• The displayed scrollbars are active.

[Actual result]:

• The displayed scrollbars are inactive.

[Regression Range]:

• Due to the fact that this issue is not reproducible on Firefox Release 69, using the mozregression tool I’ve run a regression range and reached the following pushlog:
  11:02.43 INFO: Last good revision: 0bbd8e64cb9cbef70d12bcf502a8948882b63fe9
  11:02.43 INFO: First bad revision: 16d1399f602c8a336e8f6e7a160f0e698aff486d
  11:02.43 INFO: Pushlog:
  https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=0bbd8e64cb9cbef70d12bcf502a8948882b63fe9&tochange=16d1399f602c8a336e8f6e7a160f0e698aff486d

It seems like this issue was introduced with this export and possibly by this bug 1563741.

[Notes]:

• I’ve attached a screen recording with the issue.

@Emilio, could you please take a look at this?

Comment 1

[Emilio Cobos Álvarez (:emilio)]

That regression range is necessarily wrong, that patch only touched tests.

Comment 2

[Andreea Cupsa [:acupsa], Experiments QA]

@Emilio, I will run a new regression range on a different OS.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

That makes much more sense :)

Comment 4

[Andreea Cupsa [:acupsa], Experiments QA]

@Emilio, sorry about this.
I rerun the regression range on Windows 10x 64 and reached the same pushlog. However, on MacOS I've reached a different regression range:

11:02.43 INFO: Last good revision: 0bbd8e64cb9cbef70d12bcf502a8948882b63fe9
11:02.43 INFO: First bad revision: 16d1399f602c8a336e8f6e7a160f0e698aff486d
11:02.43 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=0bbd8e64cb9cbef70d12bcf502a8948882b63fe9&tochange=16d1399f602c8a336e8f6e7a160f0e698aff486d

It seems like this issue was introduced with this export and possibly by this bug 1563741.

I've also updated the initial bug with this information.

@Ed, could you please take a look at this?

Comment 5

[Marcia Knous [:marcia]]

Discussed during triage, marking as won't fix for 70 per discussion.

Comment 6

[Pascal Chevrel:pascalc]

Tim, could you triage this regression wrt to our upcoming releases? Thanks

Comment 7

[Tim Spurway [:tspurway]]

Aaron, could you weigh in on how important this regression is from a UX perspective? How "bad" is this for the user - is it a "must fix asap", "nice to have" or "edge case" or some other granularity of importance?

Comment 8

[Aaron Benson]

I'd say this is a "must fix asap" since it could have negative repercussions for successfully navigating the page at a critical part of the user journey.

Comment 9

[Emily McMinn :emcminn]

Is it possible that this is a Windows-only bug? I've been unable to reproduce it locally. (on Mac) Thanks!

Comment 10

[Ed Lee :Mardak]

Mac by default hides scrollbars unless scrolling or keyboard/mouse are plugged in. You can change your System Preferences -> General -> Show scroll bars

Comment 11

[Emily McMinn :emcminn]

(In reply to Ed Lee :Mardak from comment #10)

Mac by default hides scrollbars unless scrolling or keyboard/mouse are plugged in. You can change your System Preferences -> General -> Show scroll bars

My scrollbars are visible & working as expected - I can't duplicate the inactive scrollbars at 25% width.

Comment 12

[Ed Lee :Mardak]

Can you click on the scrollbars or are you using the "scrollwheel" / "scroll" gesture?

Comment 13

[Emily McMinn :emcminn]

(In reply to Ed Lee :Mardak from comment #12)

Can you click on the scrollbars or are you using the "scrollwheel" / "scroll" gesture?

Both work for me!

Comment 14

[Ed Lee :Mardak]

See comment 9

Comment 15

[Andreea Cupsa [:acupsa], Experiments QA]

@Emily, I have retested this issue and I can confirm that is reproducible on all OS-es (Windows, Mac, and Linux). I also tested the issue on a Macbook Air 10.14.6.
As Ed specified in Comment 10 the "Show scroll bars" option was set to "Always" and the scrollbars are displayed as inactive.
However, if the "Show scroll bars" option is set to "When scrolling", the scrollbars are not displayed at all.

Comment 16

[Emily McMinn :emcminn]

Thanks, @Andreea! I've been able to duplicate it now - for me "Always" will duplicate the bug, but "when scrolling" seems to have the correct behavior. I'll try to find a solution that works for both :)

Comment 17

[Emily McMinn :emcminn]

Attachment: Bug 1589038 - Allow about:welcome modal scrollbars to be clicked on narrow windows

Scrollbars are now correctly active and clickable at less than 25% of window size, regardless of the system settings for scrollbars.

Comment 18

[Julien Cristau [:jcristau]]

This seems to have been awaiting review for a couple of weeks?

Comment 19

[Ed Lee :Mardak]

Added review comments requiring changes

Comment 20

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0d526197ba71
Allow about:welcome modal scrollbars to be clicked on narrow windows r=Mardak

Comment 21

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/0d526197ba71

Comment 22

[Andreea Cupsa [:acupsa], Experiments QA]

I have verified that this issue is no longer reproducible on Firefox Nightly 73.0a1 (Build ID: 20191219095006) on Windows 10 x64, Mac 10.14.6 and Ubuntu 18.04.2. The scrollbars are active when the browser is minimized below 25%.