1589066 - Replace sweep methods with traceWeakEdges in Realm

Status: RESOLVED FIXED

(Core :: JavaScript: GC, enhancement, P3)

Description

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

• js::ObjectGroupRealm::NewEntry::needsSweep
  • js::ObjectGroupRealm::ArrayObjectKey::needsSweep
  • js::ObjectGroupRealm::PlainObjectKey::needsSweep
  • js::ObjectGroupRealm::PlainObjectEntry::needsSweep
  • js::ObjectGroupRealm::AllocationSiteKey::needsSweep
  • js::ObjectGroupRealm::AllocationSiteKey::needsSweep
  • bool JS::Realm::globalIsAboutToBeFinalized()
  • js::InitialShapeEntry::needsSweep
    Also for GCHash*

Comment 1

[Jon Coppeard (:jonco)]

(In reply to Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh] from comment #0)
ObjectGroupRealm has gone away but some other cases remain.

Comment 2

[Jon Coppeard (:jonco)]

Attachment: Bug 1589066 - Part 1: Use TraceWeakEdge to trace the Realm's edge to the global r?sfink

This uses the new API to trace the edge to the global and clean up if necessary.

The method gets renamed as it only traces this one edge now, and the
traceGlobal gets renamed to traceGlobalData to avoid ambiguity.

Comment 3

[Jon Coppeard (:jonco)]

Attachment: Bug 1589066 - Part 2: Remove unused RealmNeedsSweep API and implementation r?sfink

Depends on D128347

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/57ff5c7c6e41
Part 1: Use TraceWeakEdge to trace the Realm's edge to the global r=sfink
https://hg.mozilla.org/integration/autoland/rev/a50373dbcd45
Part 2: Remove unused RealmNeedsSweep API and implementation r=sfink

Comment 5

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/57ff5c7c6e41
https://hg.mozilla.org/mozilla-central/rev/a50373dbcd45